Re: [quicwg/base-drafts] Grease values in HTTP/QUIC (#1446)
Martin Thomson <notifications@github.com> Fri, 15 June 2018 14:08 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF924130E19 for <quic-issues@ietfa.amsl.com>; Fri, 15 Jun 2018 07:08:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B5xjAtgACycz for <quic-issues@ietfa.amsl.com>; Fri, 15 Jun 2018 07:08:06 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 64778130DDA for <quic-issues@ietf.org>; Fri, 15 Jun 2018 07:08:06 -0700 (PDT)
Date: Fri, 15 Jun 2018 07:08:05 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529071685; bh=aDLa1BXEt1ZuiAc33SxsjelfEO3lcbiFatrPjMQlNxQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Abqt9fLrdsdzB75VcTOHI6/o0Nk+/7nLEIk3usK5vgrYZS4ykWhpqQzRmbvWdPjPW UUBP+/CysJWoWAZGArin/I8VVIUzRxw2XRivFI3KJ9cw9E4IEr/nnUeJMD1bE89ySF VnyqUrWSXruvoq8JptvnsBJM2h7RRi9IxxWGUg7g=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2de6151c136a53cb0bb9a78b78ef6d11fae7610792cf00000001173b8a4592a169ce13d31ec6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1446/review/129161979@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1446@github.com>
References: <quicwg/base-drafts/pull/1446@github.com>
Subject: Re: [quicwg/base-drafts] Grease values in HTTP/QUIC (#1446)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b23c84542e90_55472af96d590f602184c9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/LIQ8Tc2IFbVS0yWCxmZ5DgGXxsA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2018 14:08:10 -0000
martinthomson commented on this pull request. Generally looks good. A few places where this SHOUTS unnecessarily though. > @@ -526,6 +526,16 @@ A frame includes the following fields: ## Frame Definitions {#frames} +Frame types of the format `0xb + (0x1f * N)` are reserved to exercise the +requirement that unknown types be ignored. These frames have no semantic +meaning, and SHOULD be sent when application-layer padding is desired. They MAY s/SHOULD/can/ > @@ -526,6 +526,16 @@ A frame includes the following fields: ## Frame Definitions {#frames} +Frame types of the format `0xb + (0x1f * N)` are reserved to exercise the +requirement that unknown types be ignored. These frames have no semantic +meaning, and SHOULD be sent when application-layer padding is desired. They MAY +also be sent on connections where no request data is currently being +transferred. Endpoints MUST NOT consider these frames to have any meaning upon +receipt. + +Both the payload and length of the frames SHOULD be selected randomly, subject You can't select the length randomly if the purpose is to pad. Exposing the state of your RNG is considered bad practice now, so don't suggest random content either. Maybe instead just say that the length and contents of the frame can be anything and no more than that. > @@ -776,6 +786,14 @@ The following setting is defined in HTTP/QUIC: : An integer with a maximum value of 2^30 - 1. The default value is unlimited. +Settings values of the format `0x?a?a` are reserved to exercise the requirement +that unknown parameters be ignored. Such settings have no defined meaning. +Endpoints SHOULD include at least one such setting in their SETTINGS frame. +Endpoints MUST NOT consider such settings to have any meaning upon receipt. + +Because the setting has no defined meaning, the value of the setting SHOULD be +selected randomly, subject to implementation-defined limits on the size. s/SHOULD/can be set to any value/ > @@ -1418,6 +1446,16 @@ The entries in the following table are registered by this document. | MAX_HEADER_LIST_SIZE | 0x6 | {{settings-parameters}} | |----------------------------|------|-------------------------| +Additionally, each code of the format `0x?a?a` where each `?` is any octet (that ? isn't an octet -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1446#pullrequestreview-129161979
- Re: [quicwg/base-drafts] Grease values in HTTP/QU… Mike Bishop
- Re: [quicwg/base-drafts] Grease values in HTTP/QU… Mike Bishop
- Re: [quicwg/base-drafts] Grease values in HTTP/QU… Mike Bishop
- Re: [quicwg/base-drafts] Grease values in HTTP/QU… Mike Bishop
- Re: [quicwg/base-drafts] Grease values in HTTP/QU… Martin Thomson
- Re: [quicwg/base-drafts] Grease values in HTTP/QU… Lucas Pardue
- [quicwg/base-drafts] Grease values in HTTP/QUIC (… Mike Bishop