Re: [quicwg/base-drafts] clarify that persistent congestion is a contigous loss across all PN spaces (#3940)

Marten Seemann <notifications@github.com> Wed, 22 July 2020 05:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB1263A0DE0 for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 22:23:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wyRcvDNHsMHY for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 22:23:10 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 326E33A0DDD for <quic-issues@ietf.org>; Tue, 21 Jul 2020 22:23:10 -0700 (PDT)
Received: from github-lowworker-39ac79b.ac4-iad.github.net (github-lowworker-39ac79b.ac4-iad.github.net [10.52.18.15]) by smtp.github.com (Postfix) with ESMTP id 6AFF46E0090 for <quic-issues@ietf.org>; Tue, 21 Jul 2020 22:23:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595395389; bh=+4mJB8+gB49AlA7/yGmFLK8SPf/C9r6utZOBUT8CoL8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AGRT2O1vjbMXOe3JoyWAQ8dhhVAaeg8cCJ2jHIpOvXD7wfxnZL1TQsckrSx3T3itm jEPawbn9SGnrUtqFAP0GLUErIh9jpxIjA7U+Umbp32H6lar0K4MJV+J8ycR7V4Xdf4 ZDoSQNuY2R/kLNShn8wFc2kBrDDpYlFpEB1G/GOo=
Date: Tue, 21 Jul 2020 22:23:09 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3ANN4BRCSIXCEJDXV5EOXD3EVBNHHCPC6KAM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3940/review/453002297@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3940@github.com>
References: <quicwg/base-drafts/pull/3940@github.com>
Subject: Re: [quicwg/base-drafts] clarify that persistent congestion is a contigous loss across all PN spaces (#3940)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f17cd3d5b4b4_52a13fe9166cd95c37415"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/LV7yAasEDUWJ1L-RKaKBQ7OLK48>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 05:23:12 -0000

@marten-seemann requested changes on this pull request.

I'm not sure this actually clarifies how to declare persistent congestion when ACKs are received for multiple packet number spaces. That is, I wouldn't know how to implement `InPersistentCongestion` based on this text.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3940#pullrequestreview-453002297