IETF Logo Mail Archive

Re: [quicwg/base-drafts] Address validation for connection migration (#732)

Marten Seemann <notifications@github.com> Tue, 15 August 2017 02:48 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0369E1324B3 for <quic-issues@ietfa.amsl.com>; Mon, 14 Aug 2017 19:48:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.395
X-Spam-Level:
X-Spam-Status: No, score=-3.395 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bif2MOEQYiuF for <quic-issues@ietfa.amsl.com>; Mon, 14 Aug 2017 19:48:57 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 363741324B1 for <quic-issues@ietf.org>; Mon, 14 Aug 2017 19:48:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=kRIUX3IpsSz239IZrPPS6u/74zo=; b=Veoe+gy0khpQGbdl Grhx6J2/VTuLAx54XoYu1edQeEHEgC8qDBP3jopBIKn3S8CBtQZ0aTYkzz1/zVoe d25dzICkxsq3LlTv4S5iJ5cEcilCvXjXVjnxRbXEJiF4eGDQ8tn6FYpAefYjpAda Cm3mGMceC+9SoG4El96bpc8biMI=
Received: by filter1100p1mdw1.sendgrid.net with SMTP id filter1100p1mdw1-21452-59926118-1B 2017-08-15 02:48:56.342518093 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0027p1mdw1.sendgrid.net (SG) with ESMTP id 6tlqdIl5QviH_hNbzMDS3A for <quic-issues@ietf.org>; Tue, 15 Aug 2017 02:48:56.340 +0000 (UTC)
Date: Tue, 15 Aug 2017 02:48:56 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe75c2cb322cce682e78fad5f4a6390ad8b1a1b9492cf0000000115aa231892a169ce0ee9dd49@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/732/review/56252662@github.com>
In-Reply-To: <quicwg/base-drafts/pull/732@github.com>
References: <quicwg/base-drafts/pull/732@github.com>
Subject: Re: [quicwg/base-drafts] Address validation for connection migration (#732)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5992611812182_17b73fdccf35bc2c1290da"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2yqXEUEhfzsj9SgMrB02q4+dXIho2X7sXEOq ZuiSS/UxZusVtSBZjQCq/DI1imwoJhpqWHSYyRA6mUhPZJXhd0h663nVOTeehnVCZuk0hUuAqU0wdY ODluaj+IfPJtIZ5tBqKMJgYFGSytkQoOISIXAq9OzLg+yZRCV7pd4LOGhrltZEnROzn7tB5nXEOs4s c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/LY_sKkaiPLCENEz7UjGFe1WW-pE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Aug 2017 02:48:59 -0000

marten-seemann commented on this pull request.



> @@ -846,6 +846,7 @@ explained in more detail as they are referenced later in the document.
 | 0x0a        | STREAM_ID_NEEDED  | {{frame-stream-id-needed}}  |
 | 0x0b        | NEW_CONNECTION_ID | {{frame-new-connection-id}} |
 | 0x0c        | STOP_SENDING      | {{frame-stop-sending}}      |
+| 0x07        | PONG              | {{frame-pong}}              |

This should be `0x0d`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/732#pullrequestreview-56252662

v2.43.4 | Report a Bug | By Email | System Status