Re: [quicwg/base-drafts] Repair rules for NEW_TOKEN (#2961)

Marten Seemann <> Fri, 09 August 2019 04:06 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id F1E05120103 for <>; Thu, 8 Aug 2019 21:06:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id aOaTHsRPaUmP for <>; Thu, 8 Aug 2019 21:06:17 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 3AA191200F8 for <>; Thu, 8 Aug 2019 21:06:17 -0700 (PDT)
Date: Thu, 08 Aug 2019 21:06:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1565323576; bh=wN2guD9HmV6hYCp3M6q3VbcYyMOCLBpExCCYmQMQmBc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=M1wNAUz76g/UCNXjGmK+sBUgkQHwk4Rw9+6d3S1mAYQVtWgOTB0q/RFW4AGLHjjDu Cuv96lysfrjwBpKcRtEtSBftOhPs0z1uVaQMAPPp8Vg0E6DNkp7SqdwTfk+Oj2WQCA j1zRPLSjg2lY/vnFihCv51vN54zQpZ5NKxXe9tFE=
From: Marten Seemann <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2961/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Repair rules for NEW_TOKEN (#2961)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d4cf13848221_11413fa253ecd96835321d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Fri, 09 Aug 2019 04:06:19 -0000

marten-seemann approved this pull request.

LGTM, but do we need some text saying that when receiving a NEW_TOKEN frame, you MUST make sure that it's not a duplicate? Otherwise, a client might just save the token twice, and effectively reuse the token.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: