Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)

Mike Bishop <notifications@github.com> Wed, 27 May 2020 20:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 26F4F3A0B29 for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 13:14:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X8auUq-lVFrx for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 13:14:04 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DAB5A3A0B27 for <quic-issues@ietf.org>; Wed, 27 May 2020 13:14:03 -0700 (PDT)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id 1EEE7C605ED for <quic-issues@ietf.org>; Wed, 27 May 2020 13:14:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590610443; bh=qLXso0hQtJkcMbGKtrTkAzpZwlu1d6L2piQqj56y89E=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=S/7rF/EfyLAfYBQs+/Xdc0ucLSR4aRqta5ku5IGJG736iuYHMJfN2O+VODDmhrLIh Pl6qar6t8+ss5pyiS3SvaGBef0EW6vafQUh9sOzNjFTmrxTmTnsd8YnrcZFNOqBOJf 4X6LyxtCeZxOgqy3WIFy0N64wEzeiDuip2/cBSUU=
Date: Wed, 27 May 2020 13:14:03 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5K3JMSD6DWVVALUDF43KVQXEVBNHHCKLSLMI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3691/review/419573888@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3691@github.com>
References: <quicwg/base-drafts/pull/3691@github.com>
Subject: Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ececa0bfef0_2f363ff6fc6cd9689004c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/LhEk46OfUrIn6DLf8X1LAmlPxqo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2020 20:14:05 -0000

@MikeBishop commented on this pull request.



>  
 * absence of the retry_source_connection_id transport parameter from the server
   after receiving a Retry packet,
 
 * presence of the retry_source_connection_id transport parameter when no Retry
-  packet was received, or

Why no "or"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3691#pullrequestreview-419573888