Re: [quicwg/base-drafts] Ack Delay and TLP (#1796)

ianswett <notifications@github.com> Mon, 01 October 2018 19:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF7A0130EA8 for <quic-issues@ietfa.amsl.com>; Mon, 1 Oct 2018 12:21:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.455
X-Spam-Level:
X-Spam-Status: No, score=-8.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kJit40b89Ayv for <quic-issues@ietfa.amsl.com>; Mon, 1 Oct 2018 12:21:27 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EB7B5130EB7 for <quic-issues@ietf.org>; Mon, 1 Oct 2018 12:21:26 -0700 (PDT)
Date: Mon, 01 Oct 2018 12:21:25 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538421685; bh=50GQJuBAK+/t/Dqzn6UMIdlSUO2GtkclEgzzQkT0CO0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FsSPRlRFS/kX9MTcCIVusdUv0bVJpVzsKlPg9UdrenWa8zpno5aGctUmI9jkAt9eE nvVbvPTFBnWkiYW5P7XYh0V0/taQm6JAGMYtpOtVKgICGiW6JJekq7p0isap93sLPX MTrkZjYpUOS3GL4vm4xa1j0GIay7zMrZHoN/v21k=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab253dcb70aff1fb0d244d069adf7afb70c8e7022f92cf0000000117ca35b592a169ce15ac2c4e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1796/c426030508@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1796@github.com>
References: <quicwg/base-drafts/pull/1796@github.com>
Subject: Re: [quicwg/base-drafts] Ack Delay and TLP (#1796)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb273b5bd98d_8c33fb4036d45c4255892"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/LkKPvdc1wDZmNLLDnPTItZ168nk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Oct 2018 19:21:29 -0000

I realize kMaxDatagramSize is in the constants section, but I'm not sure it should be a constant throughout a connection, given the existence of PMTU, so it's inclusion there may be incorrect or at least misleading.

I was thinking of tracking the number of in flight packets that are >= 1200 bytes on the sender side in addition to the number of bytes in flight and then on the receiver side, only send an ack immediately if two packets >1200 bytes are received.  That would keep the concept of full-sized packets while also allow changing the MTU during a connection without any other issues.

As I mention it, I realize this has the unintended side effect that if the sender wants to delay acks, it can send a 1199 byte packet instead of 1200 byte one.  I'm not sure if that's a feature or a bug.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1796#issuecomment-426030508