Re: [quicwg/base-drafts] Clarify text on pacing (#3667)

Martin Thomson <notifications@github.com> Tue, 19 May 2020 00:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 466BB3A0DED for <quic-issues@ietfa.amsl.com>; Mon, 18 May 2020 17:57:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.474
X-Spam-Level:
X-Spam-Status: No, score=-0.474 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=0.726, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lyBfRMcRg6AO for <quic-issues@ietfa.amsl.com>; Mon, 18 May 2020 17:57:13 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EB00A3A0DEA for <quic-issues@ietf.org>; Mon, 18 May 2020 17:57:12 -0700 (PDT)
Received: from github-lowworker-cde56e0.va3-iad.github.net (github-lowworker-cde56e0.va3-iad.github.net [10.48.25.52]) by smtp.github.com (Postfix) with ESMTP id 33D1B1C04A4 for <quic-issues@ietf.org>; Mon, 18 May 2020 17:57:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589849832; bh=zcqiOcUBsJV8ko3wIDDOy8zBbFW02sXoBAbMPgOSuuA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SfNNNCkbMVvrO4r4GKzHYXvS0PmcpRTOzYWaHtVBlxF0Uc6/MXeSxqli99nMwAq7w J6JRRTwBasRJoFSIzmh/S6Q2FVNUcIu4kSog/LMCDfjogo7sfAAzdKM91t8RebhGrY Pja5wsw4jDpGcEqwf0VkZPnsPQqj/U0ovoZhqDmc=
Date: Mon, 18 May 2020 17:57:12 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2VDGYITA4S2PFIA3V4Z4H6REVBNHHCJ7MKFM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3667/review/414030990@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3667@github.com>
References: <quicwg/base-drafts/pull/3667@github.com>
Subject: Re: [quicwg/base-drafts] Clarify text on pacing (#3667)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec32ee8248be_1e963f7f43ecd9642587f8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/LsSuWaeU-5Ig3jxx89rOKo6DGFc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2020 00:57:14 -0000

@martinthomson commented on this pull request.



> @@ -908,12 +908,10 @@ Or, expressed as an inter-packet interval:
 interval = smoothed_rtt * packet_size / congestion_window / N
 ~~~
 
-Using a value for `N` that is small, but at least 1 (for example, 1.25) ensures
-that variations in round-trip time don't result in under-utilization of the
-congestion window.  Values of 'N' larger than 1 ultimately result in sending
-packets as acknowledgments are received rather than when timers fire, provided
-the congestion window is fully utilized and acknowledgments arrive at regular
-intervals.
+Using a value for N that is low, but at least 1 (for example, 1.25) ensures that
+variations in round-trip time don't result in under-utilization of the
+congestion window. Note that a higher N results in the inter-packet interval
+becoming smaller, and a large enough N defeats purpose of pacing.

```suggestion
becoming smaller, and a large enough N defeats the purpose of pacing.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3667#pullrequestreview-414030990