IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add a loss_time per packet number space (#2451)

ianswett <notifications@github.com> Mon, 11 February 2019 16:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 20C6C13104A for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 08:24:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dpJq_oip3Pxd for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 08:24:13 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DAFD2131070 for <quic-issues@ietf.org>; Mon, 11 Feb 2019 08:24:12 -0800 (PST)
Date: Mon, 11 Feb 2019 08:24:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549902252; bh=Srv5mVD9kNCwIPk8g5JIrnmMDBwOaUirm+dIDR+qQNQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TVA9liL756bHEjOcjfy3ciZlfZzicyQZgvjLT113qcTlpF0s8I87tn5lMNSpHqQaL uhy7PcqQPoA0r3/l430/308HT+WW/zKOvGBDdS5pD3x2fIxZMOpobo+/4wVyoxjwGE rnVcdzwaefQUGjheTwrRz2aSNwSEv8LnrPlYCU7A=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9fb17b564b4ee623df756578fefdfc4a909689c892cf00000001187963ac92a169ce185e5d21@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2451/review/202200958@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2451@github.com>
References: <quicwg/base-drafts/pull/2451@github.com>
Subject: Re: [quicwg/base-drafts] Add a loss_time per packet number space (#2451)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c61a1ac76cb_3e663fe1d3ed45b44175df"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Lyt58k1oMyFZ1NyAyp1IY-9p0_c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2019 16:24:15 -0000

ianswett commented on this pull request.



> @@ -1067,14 +1066,18 @@ Pseudocode for OnLossDetectionTimeout follows:
 
 ~~~
 OnLossDetectionTimeout():
-  if (crypto packets are in flight):
+  packets_lost = false
+  for pn_space in [ Initial, Handshake, ApplicatonData ]:
+    if (loss_times[pn_space] != 0):
+      // Time threshold loss Detection
+      DetectLostPackets(pn_space)
+      packets_lost = true
+  // Don't retransmit all crypto data if a packet was just lost.
+  if (!packets_lost &&

I added GetEarliestLossTime, which I think makes this more efficient and correct.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2451#discussion_r255582852

v2.29.0 | Report a Bug | By Email | System Status