Re: [quicwg/base-drafts] Compare H2 PROTOCOL_ERROR with HTTP_GENERAL_PROTOCOL_ERROR (#2808)

Lucas Pardue <notifications@github.com> Wed, 19 June 2019 13:20 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DA4C012048A for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 06:20:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.806
X-Spam-Level:
X-Spam-Status: No, score=-6.806 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.415, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UHp-tl2lCqEJ for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 06:20:17 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F150D120489 for <quic-issues@ietf.org>; Wed, 19 Jun 2019 06:20:16 -0700 (PDT)
Date: Wed, 19 Jun 2019 06:20:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560950416; bh=EBAQSTueg2LG5Pev35M3aY/Xtiu2VcpU25lefHRFoI8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SduDFkbJOBDZnN+qGsg6zu+CeAnsnpYYLQ2IXmWtRFF4BC4fwMZ0K7Y9QOjl5kCb4 APmygO49bD1BEv81SKE7oCbE5XpsAgxbqy2YaPlNOnvw5npzdBHMTxgY+VGFj3iCZZ yKyDP8s5cgn2aSWYsZ/CLfR+I9AiG4ixDqEwKtOI=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4CDJK7ME6WMFKHEI53C5URBEVBNHHBWS37GE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2808/review/251692675@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2808@github.com>
References: <quicwg/base-drafts/pull/2808@github.com>
Subject: Re: [quicwg/base-drafts] Compare H2 PROTOCOL_ERROR with HTTP_GENERAL_PROTOCOL_ERROR (#2808)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0a369032ca_21303fe6cc2cd95c21427c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/M-l9sMGX1yTjaxQNO7ZKTVdVlRA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jun 2019 13:20:19 -0000

LPardue commented on this pull request.



> @@ -2174,8 +2174,7 @@ NO_ERROR (0x0):
 : HTTP_NO_ERROR in {{http-error-codes}}.
 
 PROTOCOL_ERROR (0x1):
-: No single mapping.  See new HTTP_MALFORMED_FRAME error codes defined in
-  {{http-error-codes}}.
+: HTTP_GENERAL_PROTOCOL ERROR in {{http-error-codes}}.

Thanks, I agree and would like to adopt that text. The annoying thing is that it add more references to error codes I'm looking to consolidate but I can try to update the text to match the state of the draft as the PRs get merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2808#discussion_r295292255