IETF Logo Mail Archive

Re: [quicwg/base-drafts] Change error codes from 16-bit to varints (#2680)

Mike Bishop <notifications@github.com> Fri, 10 May 2019 19:11 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 77C561200B8 for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 12:11:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.606
X-Spam-Level:
X-Spam-Status: No, score=-1.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kXajC3xgNWPP for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 12:11:12 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BDE1112006D for <quic-issues@ietf.org>; Fri, 10 May 2019 12:11:12 -0700 (PDT)
Date: Fri, 10 May 2019 12:11:11 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557515471; bh=FmooBKOXqxBakHtgif4YLK4UuhSEmhYlj+du9V1apwU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=W3ncjiBIHB6UWkfukSFwMVhKC9kI/PpSHmsqSeJ56kKQal9gjg5NCCEVORb7APLCy hxyOljSSZNdzuRt7wGR2W2u90mlAo39jUS1AbC7JKvaJBkJggFOgL9dRvwmW1NDoRn pQCnogVmQWeMrM5u8EvDZgaYdOgZOXQVpOnv5CEA=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYQ4VDCRD5HCEM2HIV24L7U7EVBNHHBUXBX44@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2680/review/236268408@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2680@github.com>
References: <quicwg/base-drafts/pull/2680@github.com>
Subject: Re: [quicwg/base-drafts] Change error codes from 16-bit to varints (#2680)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd5cccfdcd41_26213fa5f62cd964106835"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/M3n27QmV530QGKG66FyfXtNNZeI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 May 2019 19:11:14 -0000

MikeBishop commented on this pull request.



> @@ -4537,8 +4537,9 @@ Stream ID:
 
 Application Protocol Error Code:
 
-: A 16-bit application protocol error code (see {{app-error-codes}}) which
-  indicates why the stream is being closed.
+: A variable-length integer indicating the application protocol error

Two uses of "indicat[e|ing]" in the same sentence might not flow so well.
```suggestion
: A variable-length integer containing the application protocol error
```

> @@ -4579,8 +4580,8 @@ Stream ID:
 
 Application Error Code:
 
-: A 16-bit, application-specified reason the sender is ignoring the stream (see
-  {{app-error-codes}}).
+: A variable-length integer carrying the application-specified reason the

Whatever word you choose at 4540, use it here too.

>  
 Registrations MUST include the following fields:
 
 Value:
 
 : The numeric value of the assignment (registrations will be between 0x0000 and
-  0xfeff).
+  0x3fff).

```suggestion
  0x3fffffffffffffff).
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2680#pullrequestreview-236268408

v2.23.0 | Report a Bug | By Email