IETF Logo Mail Archive

Re: [quicwg/base-drafts] One close frames (#1900)

ianswett <notifications@github.com> Wed, 24 October 2018 13:06 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 76962124408 for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 06:06:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uW2M-d6lFEx5 for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 06:06:22 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5304412F295 for <quic-issues@ietf.org>; Wed, 24 Oct 2018 06:06:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=X0U7yWRSiwRUZJwhWIEUMzP2W3w=; b=DqkWapvrVB9318Rq GnDWfTZERrR1saIbQSjzi2QKR2tlH3DgPi+eZWip8JRQiniPCuqKeyKOf81DgXNp TPEaJAoc9t+D7CHbeC4CBWDDDMHQ52FXrX7KRADuYJclIpDQGH6rHmE/iXWMlhCO xi6TApjtXn0+A3dVkOnQJ9IPTjA=
Received: by filter0341p1iad2.sendgrid.net with SMTP id filter0341p1iad2-12591-5BD06E4C-2A 2018-10-24 13:06:20.687587922 +0000 UTC m=+469475.945619947
Received: from github-lowworker-e711880.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id pQ6ixK6LRfyUmKwQRac9jA for <quic-issues@ietf.org>; Wed, 24 Oct 2018 13:06:20.547 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e711880.cp1-iad.github.net (Postfix) with ESMTP id 835CE44179E for <quic-issues@ietf.org>; Wed, 24 Oct 2018 06:06:20 -0700 (PDT)
Date: Wed, 24 Oct 2018 13:06:21 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf7549e5c127c83e807f4e27ce460b0148f649a8892cf0000000117e8304c92a169ce164012de@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1900/review/167895568@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1900@github.com>
References: <quicwg/base-drafts/pull/1900@github.com>
Subject: Re: [quicwg/base-drafts] One close frames (#1900)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd06e4c81969_7f0a3fd363ed45c48636c5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1itlwdISeL3k/QK5QAzsTHcpRtobT7Gx3YUq GfD/BFuvQxg82FAyOKsdnvaTpAI3uRTKtMmazrCE/qfkwTzq85Za3OhdLAD2OgjUxaKrm50rN8STgc 75PW3VVordSvS+6UIzrFVBF6ioWfAbH6dA3ejqdqTZ9R7EDzl6fCfjcQfAcuyK1eY6ATyXfxldEaWW g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/M5YMjzLffUzmX6sGqtlqB9eaNVw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 13:06:24 -0000

ianswett commented on this pull request.



> @@ -4055,9 +4053,11 @@ Final Offset:
 
 ## CONNECTION_CLOSE frame {#frame-connection-close}
 
-An endpoint sends a CONNECTION_CLOSE frame (type=0x02) to notify its peer that
-the connection is being closed.  CONNECTION_CLOSE is used to signal errors at
-the QUIC layer, or the absence of errors (with the NO_ERROR code).
+An endpoint sends a CONNECTION_CLOSE frame (type=0x02 or 0x03) to notify its
+peer that the connection is being closed.  The CONNECTION_CLOSE with a frame
+type of 0x02 is used to signal errors at the QUIC layer, or the absence of
+errors (with the NO_ERROR code).  The CONNECTION_CLOSE frame with a type of 0x03
+is used to signal an error with the protocol that uses QUIC.

I'd suggest application instead of protocol in this sentence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1900#pullrequestreview-167895568

v2.28.0 | Report a Bug | By Email | System Status