IETF Logo Mail Archive

Re: [quicwg/base-drafts] Define stream limits as counts (#1906)

ianswett <notifications@github.com> Thu, 25 October 2018 15:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0688F130E94 for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 08:38:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RwGMaYkKaJiR for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 08:38:50 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DDC2A130EBD for <quic-issues@ietf.org>; Thu, 25 Oct 2018 08:38:49 -0700 (PDT)
Date: Thu, 25 Oct 2018 08:38:48 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540481928; bh=9+6BsJjUVAfKUBtYNpTtQXUHBu+GzHc9tHo2R3eecb8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ASFj6SzmZAQ7aW9/Q9UMDgVfhKUm3XIVYL9JNWkcZklMY29X7a/k3NIfHG2oE8QnP wTAnwkDVKuw4PVPGnajbPzm+xRfTyzPOZbkriBUKcpugtECSZlEvJa8lMV/a4tF7GM yZ6cb4BK8rdf+teC2IIF7WSEXXlujJ649VFS25gI=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba5bb4fff43bc398a88264f7fbe4943f15ebd27bc92cf0000000117e9a58892a169ce1646c612@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1906/review/168450360@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1906@github.com>
References: <quicwg/base-drafts/pull/1906@github.com>
Subject: Re: [quicwg/base-drafts] Define stream limits as counts (#1906)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd1e388c90b0_470c3f82a4cd45b828358b0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/M5h-WJncaLSwsTH01K1r7NRw1lg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 15:38:52 -0000

ianswett commented on this pull request.



>  
-The STREAM_ID_BLOCKED frame ({{frame-stream-id-blocked}}) can be
-used to signal a shortage of available streams. Implementations will likely
-want to increase the maximum stream ID as peer-initiated streams close.
+The STREAMS_BLOCKED frame ({{frame-streams-blocked}}) can be used to signal a
+shortage of available streams. Implementations could use this as a signal to

I think shortage is not quite specific enough.  To me, that might mean "I only have 5 available" which I don't believe is the intent?  How about "The STREAMS_BLOCKED frame ({{frame-streams-blocked}}) signals that a new stream could not be created.  Implementations can use this as a signal to the peer to send a MAX_STREAMS frame with a larger limit."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1906#pullrequestreview-168450360

v2.46.0 | Report a Bug | By Email | System Status