Re: [quicwg/base-drafts] are flow control frames really idempotent? (#1612)

Martin Thomson <notifications@github.com> Tue, 31 July 2018 03:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F399130E02 for <quic-issues@ietfa.amsl.com>; Mon, 30 Jul 2018 20:57:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bLxTDEUliy6R for <quic-issues@ietfa.amsl.com>; Mon, 30 Jul 2018 20:57:44 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4C6CA130DF9 for <quic-issues@ietf.org>; Mon, 30 Jul 2018 20:57:44 -0700 (PDT)
Date: Mon, 30 Jul 2018 20:57:42 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533009462; bh=rAavF36DHp/+u5bVnlKjOfQVVDHM6IXEtHGpcu8GexM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=b759sJPUaAKnht0zRSKfHhBejWdGccmwkcZKFi3NIYdhoOqSGJjpvJCEDlAGiYZzK GGoHriRGazjNNovJRkwFTulohs1MAMkUCnztbuQfDYS02v1PtcoaHvsF4b0dHw/qB1 t+nJ56yFFhvuhrUx/Swm2PvWzixXuGYTiLSBbnfU=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab53f1c5e583ce57169d86842e465ae923e3e784b492cf000000011777a03692a169ce149fd7cc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1612/409086659@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1612@github.com>
References: <quicwg/base-drafts/issues/1612@github.com>
Subject: Re: [quicwg/base-drafts] are flow control frames really idempotent? (#1612)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b5fde3677f95_1a553fbdd6ed45bc248174"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/M8E82dPTy7UJOL4exsJZ-DfUvN0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 03:57:46 -0000

So this was opened and closed already in #447, though there wasn't a whole lot of discussion and the issue was closed with no action.

The action that @marten-seemann suggests is slightly bad - retransmitting packets is rarely the best choice from a correctness perspective - but the conclusion from the other issue was that there was little point in allowing endpoints to police continuous increases to limits.

Note that this advice would also need to apply to stream limits.

(To answer the question in the issue: Yes, these packets are still idempotent - the definition of idempotency has to allow for the state of the world to change in a way that changes the result the action when attempted again.  For example. `GET /foo` is idempotent, but if there is a `DELETE /foo` that happens, the result of another `GET /foo` will be different.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1612#issuecomment-409086659