IETF Logo Mail Archive

Re: [quicwg/base-drafts] Pad rather than shift the header protection offset (#2030)

MikkelFJ <notifications@github.com> Wed, 21 November 2018 10:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 04D4212958B for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 02:17:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4T-z4tN-8xIS for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 02:17:19 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5C5F91277D2 for <quic-issues@ietf.org>; Wed, 21 Nov 2018 02:17:19 -0800 (PST)
Date: Wed, 21 Nov 2018 02:17:18 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542795438; bh=f5VW/fegq8L/6nKg8zweaoaGz2/noT8TI+dI8wnSUFI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JAHdK9SD66mrrvNbtIf6sa8JODEuxqhhDb7m0PLTxW8EppXSQtY0HUZw5XwtWBgf2 tJtfkgjVPKGHsPcjbjd0H5htuQVP+Hi84BWt2HEBIapeLnsn5CCVk54bUdn5HgwCB7 r4mx119gdLolkEMREMbQ6wFrtrIJfhl+V6qad0Xs=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab003ecf1f445b82c5b330ad85aa90e7bbfc7081c592cf00000001180cf2ae92a169ce16d361fa@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2030/c440610141@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2030@github.com>
References: <quicwg/base-drafts/pull/2030@github.com>
Subject: Re: [quicwg/base-drafts] Pad rather than shift the header protection offset (#2030)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf530ae6b500_67333f993d4d45c056739a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/MBOo6MPvtmSqVlnhmSsDbbZTv9Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Nov 2018 10:17:21 -0000

Fair point @marten-seemann but then I'd rather have the current solution because the sample location can the be determined with a single branchless min operation that cost 3 machine instructions rather than stuffing padding bytes on the wire in special cases.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2030#issuecomment-440610141

v2.34.0 | Report a Bug | By Email | System Status