Re: [quicwg/base-drafts] Clarify the state a client stores with a token (#3150)

Nick Harper <notifications@github.com> Fri, 25 October 2019 03:19 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 09E6812003F for <quic-issues@ietfa.amsl.com>; Thu, 24 Oct 2019 20:19:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.596
X-Spam-Level:
X-Spam-Status: No, score=-1.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CstL0xezzbZb for <quic-issues@ietfa.amsl.com>; Thu, 24 Oct 2019 20:19:05 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 873261200F9 for <quic-issues@ietf.org>; Thu, 24 Oct 2019 20:19:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=zfeGu1WJxX704gtsDEjfW/jD05g=; b=sKIUnnxtZHBVq73s lKcd89tTOdzV6cIcQ2b8MRc8uh0eOqUUs7W7d/v5prEw5OTA7aCgPXkN9LGDiyHY qBBaxWQWsNj6SpSJ10/UAyJzPSk/4SGgIIrBr/MVSJTEkLMd9c1rtAELf0Sai7FZ CKalJBZBLC8tAu24N9agI7lWiyM=
Received: by filter1842p1mdw1.sendgrid.net with SMTP id filter1842p1mdw1-6751-5DB26947-11 2019-10-25 03:17:27.817966069 +0000 UTC m=+615325.164603408
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) by ismtpd0061p1iad1.sendgrid.net (SG) with ESMTP id sejxnrp8SQyueHkwjUQ74Q for <quic-issues@ietf.org>; Fri, 25 Oct 2019 03:17:27.784 +0000 (UTC)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id 13A109607FD for <quic-issues@ietf.org>; Thu, 24 Oct 2019 20:17:27 -0700 (PDT)
Date: Fri, 25 Oct 2019 03:17:28 +0000
From: Nick Harper <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYMC4KMQMBRDPLGFFN3X6U5PEVBNHHB5B4MBE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3150/review/306964441@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3150@github.com>
References: <quicwg/base-drafts/pull/3150@github.com>
Subject: Re: [quicwg/base-drafts] Clarify the state a client stores with a token (#3150)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db269474d2e_32893fd2c6ccd96c558c8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nharper
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak32YW/+go36XeuKe2+DclA39VHIASfYcTMfae OSoS1gF812Fe9QWPSZ+IXdjIpWOhZFWO18aMXWzQLH2//q477HNcEMPJbKdoeLzA2jMAEI+kChno6x OILeQeGfkgv+c46bA9N9c2ca6GqquDPIxNvj/CQHN8Fnj5SgHAGNreUEoy76+VJJDYaFaAG+2hojdz A=
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Oct 2019 03:19:11 -0000

nharper commented on this pull request.



> @@ -1746,7 +1747,8 @@ validate a client address.  Tokens are not integrated into the cryptographic
 handshake and so they are not authenticated.  For instance, a client might be
 able to reuse a token.  To avoid attacks that exploit this property, a server
 can limit its use of tokens to only the information needed to validate client
-addresses.
+addresses.  A server MUST NOT require the client to correlate any additional
+information with a token (e.g. a NewSessionTicket).

You're right that this isn't a testable "MUST NOT". I think the proposed language here is better suited with the language above describing a client's behavior.

Here I'm trying to provide some advice to server implementers that clients aren't going to keep track of which token came from where (or goes with which ticket), so if they expect that a token and ticket used on a new connection came from the same old connection, they're going to have a bad time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3150#discussion_r338871141