IETF Logo Mail Archive

Re: [quicwg/base-drafts] Remove error code and reason phrase from GOAWAY (#355)

Mike Bishop <notifications@github.com> Thu, 02 March 2017 22:17 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7078012968A for <quic-issues@ietfa.amsl.com>; Thu, 2 Mar 2017 14:17:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.02
X-Spam-Level:
X-Spam-Status: No, score=-2.02 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7YbG5FLkMivR for <quic-issues@ietfa.amsl.com>; Thu, 2 Mar 2017 14:17:05 -0800 (PST)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F21AB129686 for <quic-issues@ietf.org>; Thu, 2 Mar 2017 14:17:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=xdczdFdxdrcAHYPYY5ARVUT8HEM=; b=nhLZrvZrMdDQgcmJ e5my4kyHunNv1zT3zycMSdKbsNGa71rKbS0nuh+euCa17ESLTI7fppR77/mbe1lk cznLdnno+bL5jldPnzVhaNorSFtkTihVYWweRrPud88m0jytkgejDUNkqH/git7j QbG76DCKxsRdwkJRUt/CXS5Xgi0=
Received: by filter0182p1las1.sendgrid.net with SMTP id filter0182p1las1-17361-58B899DB-52 2017-03-02 22:16:59.972226572 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id bhXpdazzQzam_Xr1vF9NRA for <quic-issues@ietf.org>; Thu, 02 Mar 2017 22:16:59.886 +0000 (UTC)
Date: Thu, 02 Mar 2017 14:16:59 -0800
From: Mike Bishop <notifications@github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/355/review/24858634@github.com>
In-Reply-To: <quicwg/base-drafts/pull/355@github.com>
References: <quicwg/base-drafts/pull/355@github.com>
Subject: Re: [quicwg/base-drafts] Remove error code and reason phrase from GOAWAY (#355)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_58b899dbc096b_75c63fb274bc3c3c219076"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1r7a4EGOiNDcJ4yP/DEx5/2Ioy4SaqqpfYDk odBer1zhUAt3SZd2pCV3c0UseCVUCFrUEdqUCyouG9DWdOsKRl915Q63zjNpsujBKrczxFd0QIIwuF QaOkvw4hpeYxPfgRh4jqbMm2dmShhTW1PJT05SQwtC8h+1TX06B9uxwueAXQSV5HBdq3MLjCWUIT5a M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/MEXXpkPQwc7JIOrFqEKjLuBtH8c>
Cc: Subscribed <subscribed@noreply.github.com>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.17
Reply-To: quic@ietf.org
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Mar 2017 22:17:06 -0000

MikeBishop commented on this pull request.



>  
-* Reason Phrase Length: A 16-bit unsigned number specifying the length of the
-  reason phrase.  This may be zero if the sender chooses to not give details
-  beyond the error code.
+Last Server Stream ID:
+
+: The last server-initiated Stream ID which was accepted by the sender of the

Because the sender isn't necessarily the server, and the client isn't "creating" server-initiated streams.  Maybe we could say "the highest ... ID on which the sender has processed or will process data"?  But that doesn't seem more compact, so I'm not sure it's an improvement.

But regardless, that's feedback on #354, not this change in particular.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/355#discussion_r104044159

v2.46.0 | Report a Bug | By Email | System Status