Re: [quicwg/base-drafts] intial packet number should be 0. (#864)

[ekr <[e-mail]>]

Note that if we are starting at 0, you can just use int64_t, tear the
connection down at 2^{63} and use -1 as a sentinel.

-Ekr


On Thu, Oct 12, 2017 at 2:07 PM, Ryan Hamilton <[e-mail]>
wrote:

> I don't want to pile on, but please, 1 instead of 0. It's convenient in
> code to have a sentinel value for an invalid packet number and the obvious
> choices are 0 and MAX_INT64. 0 has the nice virtual of being obvious when
> printed in base10, whereas MAX_INT64 is just some random big number. In
> addition, 0 has the property of being less than valid packet number. So
> this allows you to write code like:
>
> if current_packet.packet_number > largest_received_packet_:
> UpdateNewLargestPacket()
>
> Without needing to explicitly handle the case where
> largest_received_packet_ is MAX_INT64.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/quicwg/base-drafts/pull/864#issuecomment-336268670>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABD1oa0iWapAm8k0B-jcRuD5pubyXcWOks5srn-ZgaJpZM4P3j83>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/864#issuecomment-336270299