Date: Wed, 30 Oct 2019 00:14:06 -0700
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK6HNZY67FECQBOSS5N3YZVL5EVBNHHB5HMNYI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3164/review/308997960@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3164@github.com>
References: <quicwg/base-drafts/pull/3164@github.com>
Subject: Re: [quicwg/base-drafts] Forbid use of application-level close in
 Initial, Handshake packets (#3164)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5db9383eb2aa0_3c1b3f7e13acd96c2670f";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/MM_peAupZ1vND3Vb169Hx3LI7sk>


----==_mimepart_5db9383eb2aa0_3c1b3f7e13acd96c2670f
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

mikkelfj commented on this pull request.



> @@ -5503,6 +5503,12 @@ Reason Phrase:
   zero length if the sender chooses to not give details beyond the Error Code.
   This SHOULD be a UTF-8 encoded string {{!RFC3629}}.
 
+The application-specific variant of CONNECTION_CLOSE (type 0x1d) can only be
+sent using an 1-RTT packet ({{QUIC-TLS}}, Section 4).  An application that
+wishes to abandon a connection during the handshake can send a CONNECTION_CLOSE
+frame (type 0x1c) with an error code of 0x15a ("user_canceled" alert; see
+{{?TLS13}}) in an Initial or a Handshake packet.
+

Applications cannot send frames so this requires that the API supports it, which I think they should be recommended to support, but not necessarily be required to support.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3164#pullrequestreview-308997960
----==_mimepart_5db9383eb2aa0_3c1b3f7e13acd96c2670f
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@mikkelfj</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3164#discussion_r340457022">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -5503,6 +5503,12 @@ Reason Phrase:
   zero length if the sender chooses to not give details beyond the Error Code.
   This SHOULD be a UTF-8 encoded string {{!RFC3629}}.
 
+The application-specific variant of CONNECTION_CLOSE (type 0x1d) can only be
+sent using an 1-RTT packet ({{QUIC-TLS}}, Section 4).  An application that
+wishes to abandon a connection during the handshake can send a CONNECTION_CLOSE
+frame (type 0x1c) with an error code of 0x15a (&quot;user_canceled&quot; alert; see
+{{?TLS13}}) in an Initial or a Handshake packet.
+
</pre>
<p>Applications cannot send frames so this requires that the API supports it, which I think they should be recommended to support, but not necessarily be required to support.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3164?email_source=notifications&amp;email_token=AFTOJK7NZNR5W2YHEUHA6SDQREX35A5CNFSM4JGCFZ6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJVO6SA#pullrequestreview-308997960">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK4IB45CCVAXUSYALZDQREX35ANCNFSM4JGCFZ6A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKZCW37GP4YBTMJQYW3QREX35A5CNFSM4JGCFZ6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJVO6SA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3164?email_source=notifications\u0026email_token=AFTOJK7NZNR5W2YHEUHA6SDQREX35A5CNFSM4JGCFZ6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJVO6SA#pullrequestreview-308997960",
"url": "https://github.com/quicwg/base-drafts/pull/3164?email_source=notifications\u0026email_token=AFTOJK7NZNR5W2YHEUHA6SDQREX35A5CNFSM4JGCFZ6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJVO6SA#pullrequestreview-308997960",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5db9383eb2aa0_3c1b3f7e13acd96c2670f--