Re: [quicwg/base-drafts] Don't store or retransmit PATH_RESPONSE frames, avoid buffering (#2729)

MikkelFJ <notifications@github.com> Wed, 29 May 2019 05:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F3C6D1200FE for <quic-issues@ietfa.amsl.com>; Tue, 28 May 2019 22:18:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.008
X-Spam-Level:
X-Spam-Status: No, score=-3.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hkxg0iL1pVW7 for <quic-issues@ietfa.amsl.com>; Tue, 28 May 2019 22:18:25 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5CC24120047 for <quic-issues@ietf.org>; Tue, 28 May 2019 22:18:25 -0700 (PDT)
Date: Tue, 28 May 2019 22:18:23 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1559107103; bh=lnM3NrXcnr1H6+Ds3MAE+QFT++hkA87oqhTVI1xBdBU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TE/i0O126B+ElqaFoWEJ/4YQ2qNu8DDInVlrDlRCElSSRZ/qrRDlkMofWvPDE2Ulf GUuoJ55C4Q8ZCxqwjqtQvZlfc4kVSVIkB3Cy2kaYyeydcZRl5Ps8q2f8FMJqYIujte Irc8AWf1VDNHP3+Hb4IUANTw3QmF/hK6eiVBavjY=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYGHEVEJJTKXI7YESN27NEJ7EVBNHHBVGEZF4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2729/review/243042649@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2729@github.com>
References: <quicwg/base-drafts/pull/2729@github.com>
Subject: Re: [quicwg/base-drafts] Don't store or retransmit PATH_RESPONSE frames, avoid buffering (#2729)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cee161f9ee27_c9d3fa9ceacd96c15351"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Mc0OjiMqHyRM-yEr2teTi3d9VOs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 May 2019 05:18:27 -0000

mikkelfj commented on this pull request.



> @@ -1721,7 +1721,12 @@ it can associate the peer's response with the corresponding PATH_CHALLENGE.
 ## Path Validation Responses
 
 On receiving a PATH_CHALLENGE frame, an endpoint MUST respond immediately by
-echoing the data contained in the PATH_CHALLENGE frame in a PATH_RESPONSE frame.
+echoing the data contained in the PATH_CHALLENGE frame in a PATH_RESPONSE frame,
+unless it has PATH_RESPONSE frames buffered for the same destination connection
+ID and wishes to limit memory consumption.
+
+An endpoint MUST NOT store or retransmit a PATH_RESPONSE frame, as a new
+PATH_CHALLENGE frame will be sent if another PATH_RESPONSE frame is needed.
 

I don't understand this: "unless it has PATH_RESPONSE frame buffered" and later "MUST NOT store"? why would you buffer a response and then not send it, and why would you buffer if you are not allowed to?  And why would it limit memory to buffer and why would it use less memory when choosing not to send the buffered data?

Do you mean "unless a PATH_RESPONSE has already been sent to the same destination connection ID?"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2729#pullrequestreview-243042649