Re: [quicwg/base-drafts] Simplify TLP and RTO into Probe Timeout (#2114)

ianswett <notifications@github.com> Wed, 12 December 2018 10:35 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F04312F1AC for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 02:35:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.056
X-Spam-Level:
X-Spam-Status: No, score=-3.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VwJr3xLkSzXt for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 02:35:37 -0800 (PST)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1FA2A12F1A6 for <quic-issues@ietf.org>; Wed, 12 Dec 2018 02:35:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ubXIstxS07RNIzYS8vCf76kVv0Y=; b=BWSEAtchzxjbShSR qZgrAuQTYfBRlxpy4zKm7cuIPftH60+hL4JU1ti9aKBRgIvC/AHG2ERJHcv8IdxU Vj5CEyq/jnegdd91WTC4srE0Z8q8oRLshYYWQ6VhAp+ohEFmpAO19BnyGwIhQCW5 zDV/uCteLhDzwBwnd3id6hYLG1Y=
Received: by filter0652p1las1.sendgrid.net with SMTP id filter0652p1las1-27362-5C10E478-1 2018-12-12 10:35:36.07896467 +0000 UTC m=+24434.793960267
Received: from github-lowworker-dcd58f3.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0047p1iad1.sendgrid.net (SG) with ESMTP id QBGSwOVkQgiAU5xqTvydGw for <quic-issues@ietf.org>; Wed, 12 Dec 2018 10:35:35.974 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dcd58f3.cp1-iad.github.net (Postfix) with ESMTP id ED0A12411EF for <quic-issues@ietf.org>; Wed, 12 Dec 2018 02:35:35 -0800 (PST)
Date: Wed, 12 Dec 2018 10:35:36 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab625b9feda9a879a79929a65b4f411b66e84d55dd92cf000000011828a67792a169ce173c5dcf@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2114/review/184109737@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2114@github.com>
References: <quicwg/base-drafts/pull/2114@github.com>
Subject: Re: [quicwg/base-drafts] Simplify TLP and RTO into Probe Timeout (#2114)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c10e477eba18_484b3f92096d45b828556d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3I1/ADK52qG0/ONbRRoRPe/toQm4rnRbT8W1 yb3kOYKQ/Fp96f++2lPUh14MT/kXyDPUZLjQICu8voBx8lv11G5g5NR7zTE4CKIY2XBVyndgI7CCZz jrTNofKYbJTSxaOYn03N+ezAYU2ZSgTZ3iuCfF3EHETvk/adIaVEZq2mJg==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/N5l1osBW-Oh4nE17896TbkryJAY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Dec 2018 10:35:39 -0000

ianswett commented on this pull request.



>  
-## Retransmission Timeout
+A PTO expiration is classified as spurious or valid when an ACK frame is
+received that newly acknowledges packets in flight, see {{pto-loss}}.  On a
+valid PTO, the congestion window MUST be reduced to the minimum congestion
+window and slow start is re-entered.

If you have a lot of tails(ie: HTTP traffic), then it doesn't take too many packet losses to end up hitting this.  TLP was targeted partially at cases like that, and I think you'll find changing it will produce measurable performance regressions in web traffic.  We can do something else in a follow-up, but as I said before, I'd prefer text saying SHOULD consider an acknowledgement of the first PTO as standard packet loss, not extreme congestion, and treat it as such.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2114#discussion_r240960383