Re: [quicwg/base-drafts] QUIC ack frames now store more than 255 ack ranges (#906)
Ryan Hamilton <notifications@github.com> Thu, 09 November 2017 20:27 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 13ACC129B33 for <quic-issues@ietfa.amsl.com>; Thu, 9 Nov 2017 12:27:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.181
X-Spam-Level:
X-Spam-Status: No, score=-3.181 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6O0k_rsQz4Qg for <quic-issues@ietfa.amsl.com>; Thu, 9 Nov 2017 12:27:34 -0800 (PST)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9320F12421A for <quic-issues@ietf.org>; Thu, 9 Nov 2017 12:27:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=qjUQmOPHWsiGCqv/AFQEUpDndDU=; b=vIba8emYmve/sqPr QHdcYBzzennXe7gACZmcARX7M6DlrlCyHY7I56/D2AhtdJNNn2jEYHMaL4bLptiI kY2gOAJweUOKZRCz9v7TvqTVruzge7GKaiQUE/lOEmaxZwqNbUjH4To8slZGwvRf XuJI0Lybzpy7116RHms7JZMCfAs=
Received: by filter0573p1las1.sendgrid.net with SMTP id filter0573p1las1-22462-5A04BA35-11 2017-11-09 20:27:33.318566788 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0007p1iad1.sendgrid.net (SG) with ESMTP id JQKPNC6mQwGu90irM7euCw for <quic-issues@ietf.org>; Thu, 09 Nov 2017 20:27:33.240 +0000 (UTC)
Date: Thu, 09 Nov 2017 20:27:33 +0000
From: Ryan Hamilton <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfa56fd154d1034dfbb10962b72dd06d56eae4b0292cf00000001161c7c3592a169ce10372aba@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/906/343281093@github.com>
In-Reply-To: <quicwg/base-drafts/issues/906@github.com>
References: <quicwg/base-drafts/issues/906@github.com>
Subject: Re: [quicwg/base-drafts] QUIC ack frames now store more than 255 ack ranges (#906)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a04ba35232e0_59503fa7a886ef2c5553bc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: RyanAtGoogle
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
tracking:
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak317oCYRnVPTW6CRk2HD87Z8hQrr1Ce0+Tein A88rM5YGF5ziDBtczMcB8VOYmu4gHsJNE9Y8eGMEJEzf8B1Tl8UlaOzEfwLO/z2G52OcHMYiQMHjQP IFjz3O9UhaPzopGItYRCKtfR5aoOhqBPfpK3XRHvLabeJfNa3sZ9rdTnZFvKmR/qtuaB+VoNZlQxy4 c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/N977amPpKdxRzEw8ByfCjVciTYE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Nov 2017 20:27:36 -0000
More than 255 ACK ranges in a packet seems excessive to me. (Honestly 16 is probably fine). I'd be inclined to revert this field back to single byte and limit the number of ranges to 255. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/906#issuecomment-343281093
- [quicwg/base-drafts] QUIC ack frames now store mo… ianswett
- Re: [quicwg/base-drafts] QUIC ack frames now stor… Ryan Hamilton
- Re: [quicwg/base-drafts] QUIC ack frames now stor… Martin Thomson
- Re: [quicwg/base-drafts] QUIC ack frames now stor… ianswett
- Re: [quicwg/base-drafts] QUIC ack frames now stor… ianswett
- Re: [quicwg/base-drafts] QUIC ack frames now stor… janaiyengar