Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)

Martin Thomson <notifications@github.com> Tue, 08 January 2019 22:36 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 146EA1311CB for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 14:36:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.065
X-Spam-Level:
X-Spam-Status: No, score=-3.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aGzsN2UCDANB for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 14:36:47 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 924F71311C5 for <quic-issues@ietf.org>; Tue, 8 Jan 2019 14:36:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=LZJphCU0x3LvGcJyzmSswxIVTGw=; b=pjY0hxkRoLn+7xmw rQIMicp8DGIF6gVWa2CNTIn6dMWBlm9hxCawW8dF5LYJlNtay7CJR0p7sMMXqcvl goZIM8HvsXZYktvTW/AuLK2U+RY152BmDWh0u/Fj5RTwj6v6v17F2g+DLI1+wD2W AwpHEvbtwF1V8pGfNoxJvxZWKX0=
Received: by filter0059p1iad2.sendgrid.net with SMTP id filter0059p1iad2-26492-5C3525FE-1B 2019-01-08 22:36:46.515517435 +0000 UTC m=+68733.723195164
Received: from github-lowworker-f6df7df.cp1-iad.github.net (unknown [192.30.252.41]) by ismtpd0024p1mdw1.sendgrid.net (SG) with ESMTP id lAIBEXTPRymm2qKVVlLJUw for <quic-issues@ietf.org>; Tue, 08 Jan 2019 22:36:46.368 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-f6df7df.cp1-iad.github.net (Postfix) with ESMTP id 4F4C13E0324 for <quic-issues@ietf.org>; Tue, 8 Jan 2019 14:36:46 -0800 (PST)
Date: Tue, 08 Jan 2019 22:36:46 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab849807470e538cbe95bfb0a89d05d85e55d3e1a592cf00000001184ce7fe92a169ce175c9b40@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2203/review/190489740@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2203@github.com>
References: <quicwg/base-drafts/pull/2203@github.com>
Subject: Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3525fe4dfa7_63073fcf112d45b8132371"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2DxpKeBB/RJjHG6Nl/qdbzLHjWTgojmxXZLb vP1dTFqFckT9OLPqPzlmUhydwCoS7w9Mqi76VxCuN2qbMJfhTiY7haNhVSg+pES8FVBhBzwRLoKxDE FuKHNestPCVnqAusCbCBEnlkypqCXuqdVXvPXMOMcfpHuJVJHGSLo+Cqpzs6t3cKmrr13kGFsynH6j A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/N9iSdEQAAbuxDdO1jxjZ5Zg63fo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 22:36:50 -0000

martinthomson approved this pull request.

This is good.  Thanks for doing the hard work here.

> -Header Form:
-
-: The most significant bit (0x80) of byte 0 is set to 0 for the short header.
-
-Fixed Bit:
-
-: The next bit (0x40) of byte 0 is set to 1.  Packets containing a zero value
-  for this bit are not valid packets in this version and MUST be discarded.
-
-Spin Bit (S):
-
-: The sixth bit (0x20) of byte 0 is the Latency Spin Bit, set as described in
-  {{!SPIN=I-D.ietf-quic-spin-exp}}.
+packet type.  While type-specific semantics for this version are described in
+the following sections, several long-header packets in this version of QUIC
+contain these additional fields:

Is there a picture to accompany this, or are you relying on the Initial/Handshake/0-RTT pictures?

>  
-### 0-RTT Packet Numbers {#retry-0rtt-pn}
-
-<!-- TODO: Thus far, we have not really addressed 0-RTT at all. We don't even
-really say much about what it is for. This really belongs in a section for that,
-probably right after the example handshake exchanges. -->
+See Sections 2.3 of {{!TLS13}} for a discussion of 0-RTT data and its

```suggestion
See Section 2.3 of {{!TLS13}} for a discussion of 0-RTT data and its
```

>  
+~~~
++-+-+-+-+-+-+-+-+
+|1|1| 0 |R R|P P|

```suggestion
|1|1| 1 |R R|P P|
```

>  
-A Handshake packet uses long headers with a type value of 0x2.  It is
-used to carry acknowledgments and cryptographic handshake messages from the
-server and client.
+A Handshake packet uses long headers with a type value of 0x2, followed by the
+Length and Packet Number fields.  The first byte contains the Reserved and
+Packet Number Length bits.  It is used to carry acknowledgments and
+cryptographic handshake messages from the server and client.
+
+~~~
++-+-+-+-+-+-+-+-+
+|1|1| 0 |R R|P P|

```suggestion
|1|1| 2 |R R|P P|
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2203#pullrequestreview-190489740