Re: [quicwg/base-drafts] minimum payload size requirement creates awkward special case (#2049)

Marten Seemann <notifications@github.com> Sun, 25 November 2018 10:17 UTC

Date: Sun, 25 Nov 2018 02:17:11 -0800
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abce223dd02035284f9b59929f816f445f1ef0e1e292cf00000001181238a792a169ce16e4137a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2049/441429539@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2049@github.com>
References: <quicwg/base-drafts/issues/2049@github.com>
Subject: Re: [quicwg/base-drafts] minimum payload size requirement creates awkward special case (#2049)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfa76a7aba86_655c3f9ef10d45c4922fd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NDRnzLWSthUKIHKc5j8w50MTwnY>

> What I mean is that when you notice that the length of the streams is below 4 bytes, you can move them backwards and insert PADDING before them. That logic would replace the logic you have, that appends PADDING frames.

Sure, I can think of multiple ways to fix this, and I'm not concerned about performance at all. I'm concerned about correctness and implementation complexity.

My point is: I think the way of packing frames and then adding padding is a common way to pack packets, and many implementations will choose to implement it that way. The corner case I described is **very subtle**, and I expect this to be the source of nasty bugs in the future. I think we could save ourselves a lot of trouble by reverting #2030.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2049#issuecomment-441429539

[quicwg/base-drafts] minimum payload size require… Marten Seemann
Re: [quicwg/base-drafts] minimum payload size req… Kazuho Oku
Re: [quicwg/base-drafts] minimum payload size req… Kazuho Oku
Re: [quicwg/base-drafts] minimum payload size req… Marten Seemann
Re: [quicwg/base-drafts] minimum payload size req… Marten Seemann
Re: [quicwg/base-drafts] minimum payload size req… Nick Banks
Re: [quicwg/base-drafts] minimum payload size req… MikkelFJ
Re: [quicwg/base-drafts] minimum payload size req… Martin Thomson
Re: [quicwg/base-drafts] minimum payload size req… janaiyengar
Re: [quicwg/base-drafts] minimum payload size req… MikkelFJ
Re: [quicwg/base-drafts] minimum payload size req… Kazuho Oku
Re: [quicwg/base-drafts] minimum payload size req… janaiyengar
Re: [quicwg/base-drafts] minimum payload size req… Martin Thomson
Re: [quicwg/base-drafts] minimum payload size req… Marten Seemann
Re: [quicwg/base-drafts] minimum payload size req… Marten Seemann