IETF Logo Mail Archive

Re: [quicwg/base-drafts] don't allow 0 as a packet number (#832)

ianswett <notifications@github.com> Wed, 04 October 2017 14:07 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 729A3132697 for <quic-issues@ietfa.amsl.com>; Wed, 4 Oct 2017 07:07:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.615
X-Spam-Level:
X-Spam-Status: No, score=-0.615 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BWIS3nDo2Ta6 for <quic-issues@ietfa.amsl.com>; Wed, 4 Oct 2017 07:07:52 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3F51913209C for <quic-issues@ietf.org>; Wed, 4 Oct 2017 07:07:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=EUYdzxYaO4+M3TA5vdkKIwbg/+0=; b=FTk1nUidJW/QLM2O FfDhj2x6VM6P0ov23ht6NeTDBZhN9XwMCEQcfD/DyMagPEvhGu5DcG+Q38CxaY/v 4Dx4RY9mLZi4hnO4UDRuw6QdAzfzUvhqKf/BZRqAnu5Ma29kHSXqgg1fKNrljEZC vP88Zv+vsEUVpmmKym6TmADsOWY=
Received: by filter0184p1iad2.sendgrid.net with SMTP id filter0184p1iad2-21014-59D4EAFE-13 2017-10-04 14:06:54.279595944 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0017p1iad2.sendgrid.net (SG) with ESMTP id bnNKPIvPR32mxf_Vo9D6rA for <quic-issues@ietf.org>; Wed, 04 Oct 2017 14:06:54.231 +0000 (UTC)
Date: Wed, 04 Oct 2017 14:06:54 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab820afe3c114dfe1c6f41435fed6cda72b130989092cf0000000115ecacfe92a169ce0fa74d75@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/832/334166761@github.com>
In-Reply-To: <quicwg/base-drafts/issues/832@github.com>
References: <quicwg/base-drafts/issues/832@github.com>
Subject: Re: [quicwg/base-drafts] don't allow 0 as a packet number (#832)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59d4eafe2586e_1ba9d3fceccb56f28244fd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1m+RV934Nxdav5BI6cggjLznYU3e+7EDJhjq vmbUJ6GRu2iSHrX4+zCn30mMudqWaXmsVPTTE/xg+H4lVTTE283qMBqupm99b5BuyE3Clx8qtLJf/P LHVtPTK6sGfla7rgW8t6J/ycBIzhZG9/3MGaHJus38u3fNWhGlgSlBbK+SkRfCwNZHeiko/Aj/Kjo5 s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NEPasgnPQVdkwH2hMu_4JBYn1wo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Oct 2017 14:07:53 -0000

Stats are useful, but it'd nice to keep my stats code separate from my framing code.  Marten's right, this is definitely annoying to deal with, probably on the send side as well, since our code initializes packet numbers to 0 everywhere under the thought that 0 is an invalid packet number.  

It's really nice to have an invalid packet number constant, and using 0 as an invalid packet number is a lot better than using some other value in my opinion(ie: 2^64-1)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/832#issuecomment-334166761

v2.46.0 | Report a Bug | By Email | System Status