Re: [quicwg/base-drafts] use max_ack_delay = 0 before receving the TPs (#2646)

ianswett <notifications@github.com> Thu, 25 April 2019 13:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A39F2120192 for <quic-issues@ietfa.amsl.com>; Thu, 25 Apr 2019 06:45:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sR31WG-zay88 for <quic-issues@ietfa.amsl.com>; Thu, 25 Apr 2019 06:45:45 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6AD55120161 for <quic-issues@ietf.org>; Thu, 25 Apr 2019 06:45:44 -0700 (PDT)
Date: Thu, 25 Apr 2019 06:45:42 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1556199942; bh=ew8WigbXfH70HNYQnIS9YU97TBSco8W36Hbw3hrH1+Y=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wbkGHS1FYau0ZIBSzYKDXWYuR7NLz1rZ/yjPMyW6cX0n3wVIvPhk1USq8OXHg/59S 1187MOMpRkNIVrzbgHjR8Ft6Olr6aSd7GVTcx6oIY2sykwkcefcv6VdlaTiXwa5O9R NE6n0hZRIGS1LQJjF7MwD0LqxQ6H9x7TWnx1wKE8=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7F37JX2YJKQ2IYXC52Z3WINEVBNHHBUA7M3M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2646/review/230655632@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2646@github.com>
References: <quicwg/base-drafts/pull/2646@github.com>
Subject: Re: [quicwg/base-drafts] use max_ack_delay = 0 before receving the TPs (#2646)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cc1ba06d9964_47773fc57decd95c1061c6"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NF6uao59gxuP4fjayGWqregnQJI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Apr 2019 13:45:47 -0000

ianswett commented on this pull request.

It seems like this doesn't reflect the suggestion of making it 0ms for Initial and Handshake PN spaces, rather than discussing what to do before a transport param was received.  Were you going to update the PR, or keep it as is?

> @@ -309,7 +309,8 @@ parameter, see Section 18.1 of {{QUIC-TRANSPORT}}.  max_ack_delay implies an
 explicit contract: an endpoint promises to never delay acknowledgments of an
 ack-eliciting packet by more than the indicated value. If it does, any excess
 accrues to the RTT estimate and could result in spurious retransmissions from
-the peer.
+the peer.  Before receiving the transport parameters, endpoints use a value of 0

This discusses transport param defaults, not Initial and Handshake packets.  Did you intend to keep this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2646#pullrequestreview-230655632