Re: [quicwg/base-drafts] Clearer text for application errors (#3226)

ianswett <> Tue, 12 November 2019 16:09 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id DA435120835 for <>; Tue, 12 Nov 2019 08:09:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id UkeTE7F933zY for <>; Tue, 12 Nov 2019 08:09:14 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 65FF0120098 for <>; Tue, 12 Nov 2019 08:09:14 -0800 (PST)
Received: from ( []) by (Postfix) with ESMTP id AF9E76E1740 for <>; Tue, 12 Nov 2019 08:09:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1573574953; bh=eZD3bY/laKREwHuChB9Nnm9cNvEN/yFplADSuL0dCPY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mF0zdgJVi9qPEU4FCUR3nM0Pf81HSPo1l39p2X0/HWC59JCorkvWajTW0YjYeBwKF 97nzeeqqxq8937wEG5IFS+JBWH6vZLrWgIYnpKEVNEyPu4uXHaYrEVzRZ8XkNZmhVY VJoKCixC0eMwzzSsxa3cH/IP2djqwGsit5PJDdFE=
Date: Tue, 12 Nov 2019 08:09:13 -0800
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3226/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Clearer text for application errors (#3226)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dcad929a01c2_18d13fc89d8cd96c899b9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Tue, 12 Nov 2019 16:09:17 -0000

ianswett commented on this pull request.

Small comments

> @@ -2720,17 +2720,19 @@ connection in a recoverable state, the endpoint can send a RESET_STREAM frame
 ({{frame-reset-stream}}) with an appropriate error code to terminate just the
 affected stream.
-RESET_STREAM MUST be instigated by the protocol using QUIC.  RESET_STREAM
-carries an application error code.  Only the application protocol is able to
+RESET_STREAM MUST be instigated by the application protocol that uses QUIC.

STOP_SENDING instigates RESET_STREAM, so this is a bit of a confusing statement.

>  cause a stream to be terminated.  A local instance of the application protocol
 uses a direct API call and a remote instance uses the STOP_SENDING frame, which
 triggers an automatic RESET_STREAM.
-Resetting a stream without knowledge of the application protocol could cause the
-protocol to enter an unrecoverable state.  Application protocols might require
-certain streams to be reliably delivered in order to guarantee consistent state
-between endpoints.  Application protocols SHOULD define rules for handling
-streams that are prematurely cancelled by either endpoint.
+Resetting a stream without the involvement of the application protocol could
+cause the application protocol to enter an unrecoverable state.  Application
+protocols might require certain streams to be reliably delivered in order to

+1 to Lucas point.  Personally, I'd delete this sentence because I think it's not adding much and as written it's confusing.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: