Re: [quicwg/base-drafts] No octets (#1921)
ianswett <notifications@github.com> Fri, 26 October 2018 13:20 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4EE10130DEB for <quic-issues@ietfa.amsl.com>; Fri, 26 Oct 2018 06:20:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jUA2kILoyLJS for <quic-issues@ietfa.amsl.com>; Fri, 26 Oct 2018 06:20:47 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4929D12872C for <quic-issues@ietf.org>; Fri, 26 Oct 2018 06:20:47 -0700 (PDT)
Date: Fri, 26 Oct 2018 06:20:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540560046; bh=6w82PUGL3bAvLHJczXlQhlA/FK17K645uLlHBUwibEY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Eowv2h2TD7W37Ny4FlsPWIBoVjGAOEv5B7xpSQSPVFcVnWMO9xvoGm3tjuZ1JHTHC oRNLKiBCOuvHe08Y+F9pB41rSym4tVI+qjo7Mn3D633jsiOntu5L09ELCW/VX5DdV/ zT/udoybsYUTER/ej0zZbx3cuhHVZGjcP8LPcT1w=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab874bc9f8b14a2cfb65655e63ebeed9397baecf6392cf0000000117ead6ae92a169ce164d89cf@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1921/review/168816001@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1921@github.com>
References: <quicwg/base-drafts/pull/1921@github.com>
Subject: Re: [quicwg/base-drafts] No octets (#1921)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd314ae4faad_1c423fe6ab8d45c43970ef"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NMgpjsIwP7ihoVQ8vFjFWs_wCdU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Oct 2018 13:20:50 -0000
ianswett approved this pull request. Thanks Martin, this looks great. > @@ -443,8 +442,8 @@ sent as a probe into the network prior to establishing any packet loss, prior unacknowledged packets SHOULD NOT be marked as lost. A packet sent on an RTO timer MUST NOT be blocked by the sender's congestion -controller. A sender MUST however count these bytes as additional bytes in -flight, since this packet adds network load without establishing packet loss. +controller. A sender MUST however count these bytes as being in flight, since ```suggestion controller. A sender MUST however count these packets as being in flight, since ``` > @@ -618,9 +617,9 @@ sent_packets: : An association of packet numbers to information about them, including a number field indicating the packet number, a time field indicating the time a packet was sent, a boolean indicating whether the packet is ack-only, a boolean - indicating whether it counts towards bytes in flight, and a bytes - field indicating the packet's size. sent_packets is ordered by packet number, - and packets remain in sent_packets until acknowledged or lost. A sent_packets + indicating whether it counts towards bytes in flight, and a size field that + indicates the packet's size. sent_packets is ordered by packet number, and ```suggestion indicates the packet's size in bytes. sent_packets is ordered by packet number, and ``` > @@ -965,8 +964,8 @@ losses or increases in the ECN-CE counter. ## Tail Loss Probe A TLP packet MUST NOT be blocked by the sender's congestion controller. The -sender MUST however count these bytes as additional bytes-in-flight, since a TLP -adds network load without establishing packet loss. +sender MUST however count TLP packets against bytes-in-flight, since a TLP adds Good point, how about we remove the - here, because it's spelled "bytes in flight" everywhere else. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1921#pullrequestreview-168816001
- Re: [quicwg/base-drafts] No octets (#1921) Martin Thomson
- Re: [quicwg/base-drafts] No octets (#1921) Martin Thomson
- Re: [quicwg/base-drafts] No octets (#1921) Martin Thomson
- Re: [quicwg/base-drafts] No octets (#1921) Martin Thomson
- [quicwg/base-drafts] No octets (#1921) Martin Thomson
- Re: [quicwg/base-drafts] No octets (#1921) MikkelFJ
- Re: [quicwg/base-drafts] No octets (#1921) MikkelFJ
- Re: [quicwg/base-drafts] No octets (#1921) ianswett
- Re: [quicwg/base-drafts] No octets (#1921) Martin Thomson
- Re: [quicwg/base-drafts] No octets (#1921) Martin Thomson