Re: [quicwg/base-drafts] Clarify HTTP/2 setting parameter reservation (#3955)

Jana Iyengar <notifications@github.com> Fri, 24 July 2020 21:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B72993A0D4B for <quic-issues@ietfa.amsl.com>; Fri, 24 Jul 2020 14:53:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.716
X-Spam-Level:
X-Spam-Status: No, score=-1.716 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4AK-QwbdlhFC for <quic-issues@ietfa.amsl.com>; Fri, 24 Jul 2020 14:53:38 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2F9123A0D46 for <quic-issues@ietf.org>; Fri, 24 Jul 2020 14:53:38 -0700 (PDT)
Received: from github-lowworker-f144ac1.va3-iad.github.net (github-lowworker-f144ac1.va3-iad.github.net [10.48.16.59]) by smtp.github.com (Postfix) with ESMTP id 4DF9F902685 for <quic-issues@ietf.org>; Fri, 24 Jul 2020 14:53:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595627617; bh=LMEE6nKFhhbymqo2LW+NYq2Tj0706cVriJ3E85yYoIc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=L10I1lQtm0nf9AmKK/qvWwQyOHMpTICnJ1UEW4hhanVRhwJUQ+ncNQU7DqTO6MqeT ok3ixfA/61aoeXZhe1NupGe69/C/ib+GULp8C5eXJ2PkgU6oa9ds0ArPI7258bS9cz DNd21V1TpP1HxBCHcTwQWH6RrueWDFncDPewcdWE=
Date: Fri, 24 Jul 2020 14:53:37 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYYPBF4VRBHRTH5RP55E44WDEVBNHHCPHGA74@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3955/review/454585794@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3955@github.com>
References: <quicwg/base-drafts/pull/3955@github.com>
Subject: Re: [quicwg/base-drafts] Clarify HTTP/2 setting parameter reservation (#3955)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f1b58613e7bf_13913fed080cd96c13641a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NP86Bi3hut0DbZh6hEAietYkCwo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jul 2020 21:53:40 -0000

@janaiyengar commented on this pull request.



> @@ -1395,6 +1395,10 @@ settings to have any meaning upon receipt.
 Because the setting has no defined meaning, the value of the setting can be any
 value the implementation selects.
 
+Setting identifiers which were used in HTTP/2 where there is no corresponding
+HTTP/3 setting have also been reserved ({{iana-settings}}). These settings MUST
+NOT be sent, and receipt MAY be treated as an error of type H3_SETTINGS_ERROR.

```suggestion
NOT be sent, and their receipt MAY be treated as an error of type H3_SETTINGS_ERROR.
```

> @@ -1395,6 +1395,10 @@ settings to have any meaning upon receipt.
 Because the setting has no defined meaning, the value of the setting can be any
 value the implementation selects.
 
+Setting identifiers which were used in HTTP/2 where there is no corresponding
+HTTP/3 setting have also been reserved ({{iana-settings}}). These settings MUST
+NOT be sent, and receipt MAY be treated as an error of type H3_SETTINGS_ERROR.

I would be in favor of `MUST treat as error`. This isn't hard to detect, and it seems quite reasonable to close the connection on such errors.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3955#pullrequestreview-454585794