Re: [quicwg/base-drafts] Don't specify RTT in HTTP (#3358)

Kazuho Oku <notifications@github.com> Fri, 17 January 2020 22:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2272B12006B for <quic-issues@ietfa.amsl.com>; Fri, 17 Jan 2020 14:51:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nOl3KeVMuEem for <quic-issues@ietfa.amsl.com>; Fri, 17 Jan 2020 14:51:39 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 140E81208A0 for <quic-issues@ietf.org>; Fri, 17 Jan 2020 14:51:37 -0800 (PST)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id 0098D1C068B for <quic-issues@ietf.org>; Fri, 17 Jan 2020 14:51:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579301496; bh=XqOfZjhpPcEtbQGhVR5hwIOrl3hJfHYcETvSRgtY33E=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bfOrphxeuHq9L+QkGUG7zUm3vdPqifxRrKLVg/wIZRUvxKLzwmcKmKRjAIp/211KU g7YCjRyxwKv+C3fGSpGLqT9dETrjpC2IYAD7QLUbvgQm4r/lwNqgy2tdC8Z6zPx6yC 4BJobS5Jaikrp2qsd8O9VQvnPxc4G4xWUIYGbdjY=
Date: Fri, 17 Jan 2020 14:51:35 -0800
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5BVNJ4AIMDFQU6GDN4F5WPPEVBNHHCBYIASU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3358/review/344882871@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3358@github.com>
References: <quicwg/base-drafts/pull/3358@github.com>
Subject: Re: [quicwg/base-drafts] Don't specify RTT in HTTP (#3358)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e223a77e4833_464e3fe3c16cd95c158640"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NPYUWQivIBJ1SjsHoeQOIGtqlJs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2020 22:51:41 -0000

kazuho commented on this pull request.

LGTM modulo the point below.

> @@ -732,9 +732,10 @@ initial GOAWAY frame with the last Stream ID set to the maximum possible value
 for a client-initiated, bidirectional stream (i.e. 2^62-4 in case of QUIC
 version 1).  This GOAWAY frame signals to the client that shutdown is imminent
 and that initiating further requests is prohibited.  After allowing time for any
-in-flight requests (at least one round-trip time), the server would send another
-GOAWAY frame with an updated last Stream ID.  This ensures that a connection can
-be cleanly shut down without causing requests to fail.
+in-flight requests to reach the server, the server MAY send another GOAWAY frame
+indicating which requests it will accept before the end of the connection. This

Now that we do not use RFC 2119 keywords in describing the procedure of gracefully shutting down the connection, it might be a good idea to change:
"the server MAY send another GOAWAY frame indicating which requests it will accept before the end of the connection."
to: "the server will send another GOAWAY frame indicating the requests it accepted."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3358#pullrequestreview-344882871