[quicwg/base-drafts] incorrect setting of anti-deadlock timer (#3554)

Marten Seemann <notifications@github.com> Mon, 30 March 2020 05:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 10E0F3A0CFE for <quic-issues@ietfa.amsl.com>; Sun, 29 Mar 2020 22:13:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.499
X-Spam-Level:
X-Spam-Status: No, score=-5.499 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WFeL3fx8ETkz for <quic-issues@ietfa.amsl.com>; Sun, 29 Mar 2020 22:13:06 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9098C3A0D01 for <quic-issues@ietf.org>; Sun, 29 Mar 2020 22:13:06 -0700 (PDT)
Date: Sun, 29 Mar 2020 22:13:05 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585545185; bh=b7YhX3ws2lmvJnHFo0g+qWquC2W4Sf0NdB6VDWHjn48=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=V1kKdNjByrqrkM5yOXIWx8NXctLG9g47eiJO2N5C+BJBev7vdKMSrNoSYgLv9Qp5u e1rGvgbs0fsLf1BDwheOBOKDwXLGx9BTwvZK3BtSLce6/pn0P2KQd23Mnbu330CoLw PvEAzJcdGsYvmMDJqkIT8Mda6J+WPmSQ2B2ZEJlg=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYOLJA5IQFKC57FCAV4RVQODEVBNHHCGKVIJ4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3554@github.com>
Subject: [quicwg/base-drafts] incorrect setting of anti-deadlock timer (#3554)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e817fe15ac02_5fc13fee174cd96c350470"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NR7l2cFowdCrDz5BmV45CBAO02A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Mar 2020 05:13:08 -0000

Consider the following situation: The client sent the ClientHello, and received both an ACK for it and a Handshake packet from the server.
When receiving the Handshake packet, it drops the Initial packet number space, and according to https://quicwg.org/base-drafts/draft-ietf-quic-recovery.html#name-upon-dropping-initial-or-ha it sets `time_of_last_sent_ack_eliciting_packet[Initial] = 0`.

The next run on `SetLossDetectionTimer` (which will happen when sending an ACK for the Handshake packet) will run `GetEarliestTimeAndSpace`, which will return `0`, and the timer will be set to a time long ago in the past (1970, if the timer is based on UNIX timestamps).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3554