IETF Logo Mail Archive

Re: [quicwg/base-drafts] ACK_ECN type value is not incremented (#1520)

janaiyengar <notifications@github.com> Fri, 06 July 2018 20:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D41BD130F0E for <quic-issues@ietfa.amsl.com>; Fri, 6 Jul 2018 13:53:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9R6f_fpGYl5V for <quic-issues@ietfa.amsl.com>; Fri, 6 Jul 2018 13:53:39 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7062E130F5E for <quic-issues@ietf.org>; Fri, 6 Jul 2018 13:53:32 -0700 (PDT)
Date: Fri, 06 Jul 2018 13:53:31 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530910411; bh=AaweMJg7abg1eeS34kISxxuqz+TBnv2+rLvTtp25rA4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TsV7e63FIji6v5EoyQEq3a15Qagn8obTp20ZMbjZUFNlmsnXXyWFcRHCHjIDV1mW8 5yenBkAVOaXLU9yW9puAtGbBcZ1Pkq3eG8ErYSmE2hw02rEuMhDZAhJ/29iWyKB650 bnD3HSOHtOtFVc1rpd53/anih7jnHI4InJEhShwQ=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7c452276984f6f3b38e7e082850b43898f12334992cf00000001175798cb92a169ce14281420@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1520/c403144164@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1520@github.com>
References: <quicwg/base-drafts/pull/1520@github.com>
Subject: Re: [quicwg/base-drafts] ACK_ECN type value is not incremented (#1520)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3fd6cb9d4f6_5b1d3fb53bd26f8814167d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NTtISKTgzwOQ4R-v9P7nC37B1jY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 20:53:41 -0000

@martinthomson : I think this is fine, given that I don't expect that anyone has implemented the ACK_ECN frame yet. We can reduce later pain if we take this in now, I think. I'll merge.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1520#issuecomment-403144164

v2.23.0 | Report a Bug | By Email