Re: [quicwg/base-drafts] NEW_TOKEN contains globally unique values (#3281)

[Jana Iyengar <[e-mail]>]

janaiyengar commented on this pull request.



> @@ -1719,9 +1719,11 @@ encrypted form in the token.
 A token issued with NEW_TOKEN MUST NOT include information that would allow
 values to be linked by an on-path observer to the connection on which it was
 issued, unless the values are encrypted.  For example, it cannot include the
-previous connection ID or addressing information.  Information that allows the
-server to distinguish between tokens from Retry and NEW_TOKEN MAY be accessible
-to entities other than the server.
+previous connection ID or addressing information.  Each NEW_TOKEN frame MUST
+be unique among all connections to that server, unless the frame is sent to

Sorry for being pedantic, but this is a MUST and the requirement doesn't seem clear. First, this reads like a requirement on the client. If so,
- Does this imply that a client has to maintain and check _all_ NEW_TOKEN frames issued by every server for a long enough period of time?
- How would a client know whether a received NEW_TOKEN frame is a repair of a lost NEW_TOKEN frame?

If it's not meant to be a requirement on the client, how about "A server MUST ensure that every NEW_TOKEN frame it sends is unique across all clients, with the exception of those sent to repair loss of a previously sent NEW_TOKEN frame." 

Also, add a recommendation on what a client should do if it detects a server repeating NEW_TOKEN frames.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3281#pullrequestreview-329534390