Re: [quicwg/base-drafts] NEW_TOKEN contains globally unique values (#3281)

Jana Iyengar <notifications@github.com> Tue, 10 December 2019 01:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3A1B3120020 for <quic-issues@ietfa.amsl.com>; Mon, 9 Dec 2019 17:08:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EDHZkYnEpbDI for <quic-issues@ietfa.amsl.com>; Mon, 9 Dec 2019 17:08:40 -0800 (PST)
Received: from out-15.smtp.github.com (out-15.smtp.github.com [192.30.254.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CB50612002F for <quic-issues@ietf.org>; Mon, 9 Dec 2019 17:08:40 -0800 (PST)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id 27F0A26172D for <quic-issues@ietf.org>; Mon, 9 Dec 2019 17:08:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575940120; bh=XR+sLSjIAo6wyXcmFVmAg++LdLXpaFjZvtBEQqircGk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zsC2y1PcycXOn+Qk7Pz9q/PSbw9oYscgdmy2OJhT5u5GXr212ODHoUGjKTSxf3jYK P32LK5fdsfQTcnPHfGBJ5OinsFD6X1J+xopitOWF2yxjamZck36+676SB9CUPIPv/g OEcCN1Yenqcnzz6WcVh6ibEtQvxg2gx8z/FF/loI=
Date: Mon, 09 Dec 2019 17:08:39 -0800
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK32IYDEILKC3W5C3CF37QRJPEVBNHHB7MNOEU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3281/review/329534390@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3281@github.com>
References: <quicwg/base-drafts/pull/3281@github.com>
Subject: Re: [quicwg/base-drafts] NEW_TOKEN contains globally unique values (#3281)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5deef017d6641_13ab3ff1e24cd95c65958"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NVd8FrZ2v3FDX1eXvTLFXcfK9aY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Dec 2019 01:08:42 -0000

janaiyengar commented on this pull request.



> @@ -1719,9 +1719,11 @@ encrypted form in the token.
 A token issued with NEW_TOKEN MUST NOT include information that would allow
 values to be linked by an on-path observer to the connection on which it was
 issued, unless the values are encrypted.  For example, it cannot include the
-previous connection ID or addressing information.  Information that allows the
-server to distinguish between tokens from Retry and NEW_TOKEN MAY be accessible
-to entities other than the server.
+previous connection ID or addressing information.  Each NEW_TOKEN frame MUST
+be unique among all connections to that server, unless the frame is sent to

Sorry for being pedantic, but this is a MUST and the requirement doesn't seem clear. First, this reads like a requirement on the client. If so,
- Does this imply that a client has to maintain and check _all_ NEW_TOKEN frames issued by every server for a long enough period of time?
- How would a client know whether a received NEW_TOKEN frame is a repair of a lost NEW_TOKEN frame?

If it's not meant to be a requirement on the client, how about "A server MUST ensure that every NEW_TOKEN frame it sends is unique across all clients, with the exception of those sent to repair loss of a previously sent NEW_TOKEN frame." 

Also, add a recommendation on what a client should do if it detects a server repeating NEW_TOKEN frames.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3281#pullrequestreview-329534390