Re: [quicwg/base-drafts] Alternative packet format presentation (#3573)

Jana Iyengar <notifications@github.com> Fri, 10 April 2020 02:35 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5CA643A1990 for <quic-issues@ietfa.amsl.com>; Thu, 9 Apr 2020 19:35:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.721
X-Spam-Level:
X-Spam-Status: No, score=-1.721 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1X-N9UzQiII9 for <quic-issues@ietfa.amsl.com>; Thu, 9 Apr 2020 19:35:02 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1BF043A198E for <quic-issues@ietf.org>; Thu, 9 Apr 2020 19:35:01 -0700 (PDT)
Received: from github-lowworker-2300405.va3-iad.github.net (github-lowworker-2300405.va3-iad.github.net [10.48.17.39]) by smtp.github.com (Postfix) with ESMTP id EAFAFA07DE for <quic-issues@ietf.org>; Thu, 9 Apr 2020 19:35:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586486100; bh=d9sLLTSbS4L9epj7I3anuiU2+G3zZEtuA/ev3Y82tIo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SwOikAfUsOgR0MgAC1y3siOLDhd8ga3Z8/u7UXGyqH5Y3igZfXRmWF1qKGaZrN0Lz jiZ8xzaIsgHFdW3JXZTn4fwQHVaiywcLckKuv6mj6juxcbPxz/+Y+7I51EIrv1bHpZ 9hWXME2WxREz7cDDKpiED+mSMoIdpJn8tbZ1+Ptg=
Date: Thu, 09 Apr 2020 19:35:00 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2UJMBWF64AG22RB5N4TO6FJEVBNHHCHFHWFE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3573/review/391234740@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3573@github.com>
References: <quicwg/base-drafts/pull/3573@github.com>
Subject: Re: [quicwg/base-drafts] Alternative packet format presentation (#3573)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e8fdb54db388_734f3ffd26ecd96c128915"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NW8ZJaZqg6cmDUQ4kk3XMmIvbIM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Apr 2020 02:35:03 -0000

@janaiyengar approved this pull request.

I really like this format.

>  
-\[x\]:
-: Indicates that x is optional
+Complex fields are named and then followed by a list of fields surrounded by a
+pair of matching braces. Each field in this list is separated by commas.
+
+Individual fields include length information, plus indications about fixed
+value, optionality, or repetitions. Individual fields use the following
+notational conventions:

```suggestion
notational conventions, with all lengths in bits:
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3573#pullrequestreview-391234740