Re: [quicwg/base-drafts] Minor edits to amplification attack text (#1895)

ianswett <notifications@github.com> Wed, 24 October 2018 02:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 37868130DD2 for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 19:12:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id baRF4RTQ0Ie7 for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 19:12:05 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4871E128CE4 for <quic-issues@ietf.org>; Tue, 23 Oct 2018 19:12:05 -0700 (PDT)
Date: Tue, 23 Oct 2018 19:12:04 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540347124; bh=dbzXguqs3ZNV5M5zugWLToS9xoZHf1dVVpUpiExnTaI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RnUDSNa6eLOcIgfj+1/LOderZGKJduwsth47g5dO80PilaTlBMm1yH2tDGZz6hoxr 9whLMmw4K4AvHbDuvhQi0a0xG8Gv0kXE1lBPccnwuXW9SYv99GJesCglcWS0naLmh/ RHaE4t4MxgX2Emo11lTexq1kcDXKDOjNir2EG3zU=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab70c0e52117123bbb6b7ba37910c6c1327c4256b192cf0000000117e796f492a169ce162e64dc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1895/review/167706365@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1895@github.com>
References: <quicwg/base-drafts/pull/1895@github.com>
Subject: Re: [quicwg/base-drafts] Minor edits to amplification attack text (#1895)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bcfd4f457f1d_2aa43f82ab4d45b42678f7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NYvVaVs0EKIeQHZVu4y1SbNZgGc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 02:12:07 -0000

ianswett commented on this pull request.



> @@ -1194,13 +1194,14 @@ server then needs to validate that the client owns the address that it claims.
 QUIC therefore performs source address validation during connection
 establishment.
 
-Servers MUST NOT send more than three times as many bytes as the number of bytes
-received prior to verifying the client's address.  Source addresses can be
+Prior to verifying the client's address, servers MUST NOT send more than three

Q: Is this actually less awkward?  It's ok, but seems neutral to me.  Both sentences are a bit odd.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1895#pullrequestreview-167706365