Date: Tue, 23 Oct 2018 19:12:04 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab70c0e52117123bbb6b7ba37910c6c1327c4256b192cf0000000117e796f492a169ce162e64dc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1895/review/167706365@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1895@github.com>
References: <quicwg/base-drafts/pull/1895@github.com>
Subject: Re: [quicwg/base-drafts] Minor edits to amplification attack text
 (#1895)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5bcfd4f457f1d_2aa43f82ab4d45b42678f7";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NYvVaVs0EKIeQHZVu4y1SbNZgGc>


----==_mimepart_5bcfd4f457f1d_2aa43f82ab4d45b42678f7
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -1194,13 +1194,14 @@ server then needs to validate that the client owns the address that it claims.
 QUIC therefore performs source address validation during connection
 establishment.
 
-Servers MUST NOT send more than three times as many bytes as the number of bytes
-received prior to verifying the client's address.  Source addresses can be
+Prior to verifying the client's address, servers MUST NOT send more than three

Q: Is this actually less awkward?  It's ok, but seems neutral to me.  Both sentences are a bit odd.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1895#pullrequestreview-167706365
----==_mimepart_5bcfd4f457f1d_2aa43f82ab4d45b42678f7
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1895#discussion_r227622686">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1194,13 +1194,14 @@ server then needs to validate that the client owns the address that it claims.
 QUIC therefore performs source address validation during connection
 establishment.
 
-Servers MUST NOT send more than three times as many bytes as the number of bytes
-received prior to verifying the client&#39;s address.  Source addresses can be
+Prior to verifying the client&#39;s address, servers MUST NOT send more than three
</pre>
<p>Q: Is this actually less awkward?  It's ok, but seems neutral to me.  Both sentences are a bit odd.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1895#pullrequestreview-167706365">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkqzDUNdSMc9ptT19Mak-hPEN6ApKXks5un8x0gaJpZM4XxjRl">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq0X2O-TjT4usREL8ixj_g3vR0YwAks5un8x0gaJpZM4XxjRl.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ianswett commented on #1895"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1895#pullrequestreview-167706365"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1895#pullrequestreview-167706365",
"url": "https://github.com/quicwg/base-drafts/pull/1895#pullrequestreview-167706365",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ianswett commented on 1895",
"sections": [
{
"text": "",
"activityTitle": "**ianswett**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ianswett",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1895#pullrequestreview-167706365"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 398865509\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5bcfd4f457f1d_2aa43f82ab4d45b42678f7--