IETF Logo Mail Archive

Re: [quicwg/base-drafts] skip draining period in case of idle timeout (#2404)

Kazuho Oku <notifications@github.com> Mon, 04 February 2019 03:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0A8B5130DE7 for <quic-issues@ietfa.amsl.com>; Sun, 3 Feb 2019 19:29:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jHrmM2vZ5pat for <quic-issues@ietfa.amsl.com>; Sun, 3 Feb 2019 19:29:45 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1557B130DE4 for <quic-issues@ietf.org>; Sun, 3 Feb 2019 19:29:45 -0800 (PST)
Date: Sun, 03 Feb 2019 19:29:44 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549250984; bh=9+uTA6enppOo76sPeHoSKA7EiRxt+FdKtp9hKl8sK+o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=GjRObW7antbtF8hf5O7EFBu/fnyIQXqvPT+PRnMbkJVw/sSOY0JVpXKj1K6w43jed 8Qk0o+FnPFZ6jxhc8HrY7cYFBhRJrOI99PVWx2S6yYMpQNpdV+JfyDNMNsv/KAAsZ1 c2W4+8oZfab2HpxkT96Ufep6G9HCRkI6s984uRCw=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6df1a7b0caf175ba365c2c3ff0cbaceed8bfcb7592cf00000001186f73a892a169ce1835a120@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2404/review/199429714@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2404@github.com>
References: <quicwg/base-drafts/pull/2404@github.com>
Subject: Re: [quicwg/base-drafts] skip draining period in case of idle timeout (#2404)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c57b1a874ae_2c423f97324d45b43030540"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Na0FmfYRm-1Ft3MGk2FnMZDyfuM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 03:29:47 -0000

kazuho commented on this pull request.



> @@ -2276,9 +2276,10 @@ source address.
 
 ## Idle Timeout {#idle-timeout}
 
-If the idle timeout is enabled, a connection that remains idle for longer than
-the advertised idle timeout (see {{transport-parameter-definitions}}) is closed.
-A connection enters the draining state when the idle timeout expires.
+If the idle timeout is enabled, a connection is closed when it remains idle for
+longer than the larger of the advertised idle timeout (see
+{{transport-parameter-definitions}}) or three times the current Probe Timeout

Makes sense. Made the change in 9a27782 as well as consolidating the description of what to do when the timer expires.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2404#discussion_r253340833

v2.23.0 | Report a Bug | By Email