Date: Fri, 13 Dec 2019 11:25:04 -0800
From: Nick Harper <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK3JXOLZMYLQ2RNA37V4AEMBBEVBNHHB5B4MBE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3150/review/332069019@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3150@github.com>
References: <quicwg/base-drafts/pull/3150@github.com>
Subject: Re: [quicwg/base-drafts] Clarify the state a client stores with a
 token (#3150)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5df3e590b6225_392f3fb86d2cd96c695863";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NhTAYbd0uq1PSG8XLpplV3If5B4>


----==_mimepart_5df3e590b6225_392f3fb86d2cd96c695863
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

nharper commented on this pull request.



> @@ -1746,7 +1747,8 @@ validate a client address.  Tokens are not integrated into the cryptographic
 handshake and so they are not authenticated.  For instance, a client might be
 able to reuse a token.  To avoid attacks that exploit this property, a server
 can limit its use of tokens to only the information needed to validate client
-addresses.
+addresses.  A server MUST NOT require the client to correlate any additional
+information with a token (e.g. a NewSessionTicket).

Sorry for the delay. The new paragraph (framed as client considerations) sounds like a better way to describe this point. I've added a version of that paragraph and rebased this PR. (There was a merge conflict for the change above.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3150#discussion_r357796404
----==_mimepart_5df3e590b6225_392f3fb86d2cd96c695863
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@nharper</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3150#discussion_r357796404">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1746,7 +1747,8 @@ validate a client address.  Tokens are not integrated into the cryptographic
 handshake and so they are not authenticated.  For instance, a client might be
 able to reuse a token.  To avoid attacks that exploit this property, a server
 can limit its use of tokens to only the information needed to validate client
-addresses.
+addresses.  A server MUST NOT require the client to correlate any additional
+information with a token (e.g. a NewSessionTicket).
</pre>
<p>Sorry for the delay. The new paragraph (framed as client considerations) sounds like a better way to describe this point. I've added a version of that paragraph and rebased this PR. (There was a merge conflict for the change above.)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3150?email_source=notifications&amp;email_token=AFTOJKYHGWTYBMBH4WIRHIDQYPORBA5CNFSM4JE37ZY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPFPRGY#discussion_r357796404">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJKYT2CH25XLUGRVKFETQYPORBANCNFSM4JE37ZYQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKZDVZMICZYDYS2JQCLQYPORBA5CNFSM4JE37ZY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPFPRGY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3150?email_source=notifications\u0026email_token=AFTOJKYHGWTYBMBH4WIRHIDQYPORBA5CNFSM4JE37ZY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPFPRGY#discussion_r357796404",
"url": "https://github.com/quicwg/base-drafts/pull/3150?email_source=notifications\u0026email_token=AFTOJKYHGWTYBMBH4WIRHIDQYPORBA5CNFSM4JE37ZY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPFPRGY#discussion_r357796404",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5df3e590b6225_392f3fb86d2cd96c695863--