Re: [quicwg/base-drafts] Remove some cruft from packet size section (#3262)

Jana Iyengar <notifications@github.com> Wed, 20 November 2019 07:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B28A12081B for <quic-issues@ietfa.amsl.com>; Tue, 19 Nov 2019 23:01:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nwg2Z84rKtFz for <quic-issues@ietfa.amsl.com>; Tue, 19 Nov 2019 23:00:56 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 203B5120818 for <quic-issues@ietf.org>; Tue, 19 Nov 2019 23:00:56 -0800 (PST)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id 494CE660455 for <quic-issues@ietf.org>; Tue, 19 Nov 2019 23:00:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574233255; bh=sFbmgNi98Q2AlFvpPLg5Y+m8ZqyW+Mf0ym8rkg69yLc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=f6VTL2iokdvlyRPPa4viAgq10ftNXEj34vx3tAXe/A5jr2/q4faC5wRT9cSY4jWp2 xlURsVkff0Y4hfgJfkub+/lV2DTk9Yay9msJwE8JNJGFf74zPH4wrUm4HQqxoH3EmZ 3wvPBttvYSajuMF0LrQoYWiTEt4dDvk8W+mScQ4M=
Date: Tue, 19 Nov 2019 23:00:55 -0800
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK264XEM4Q4HWBJ7OF534ILSPEVBNHHB6RS4SQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3262/review/319580505@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3262@github.com>
References: <quicwg/base-drafts/pull/3262@github.com>
Subject: Re: [quicwg/base-drafts] Remove some cruft from packet size section (#3262)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd4e4a739e2c_43873fa334acd96c72933"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/No74BrTO5M3lOJH0AX0rleKtRvE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Nov 2019 07:01:01 -0000

janaiyengar commented on this pull request.

some editorializing

> @@ -3410,27 +3410,22 @@ later time in the connection.
 The QUIC packet size includes the QUIC header and protected payload, but not the
 UDP or IP header.
 
-Clients MUST ensure they send the first Initial packet in a single IP packet.
-Similarly, the first Initial packet sent after receiving a Retry packet MUST be
-sent in a single IP packet.
-
-The payload of a UDP datagram carrying the first Initial packet MUST be expanded
-to at least 1200 bytes, by adding PADDING frames to the Initial packet and/or by
-coalescing the Initial packet (see {{packet-coalesce}}). Sending a UDP datagram
-of this size ensures that the network path supports a reasonable Maximum
-Transmission Unit (MTU), and helps reduce the amplitude of amplification attacks
-caused by server responses toward an unverified client address; see
+The payload of a UDP datagram carrying Initial packets from a client MUST be

I would suggest making this active. "A client MUST expand the payload of all UDP datagrams carrying Initial packets to at least 1200 bytes, by adding PADDING ..."

> @@ -3410,27 +3410,22 @@ later time in the connection.
 The QUIC packet size includes the QUIC header and protected payload, but not the
 UDP or IP header.
 
-Clients MUST ensure they send the first Initial packet in a single IP packet.
-Similarly, the first Initial packet sent after receiving a Retry packet MUST be
-sent in a single IP packet.
-
-The payload of a UDP datagram carrying the first Initial packet MUST be expanded
-to at least 1200 bytes, by adding PADDING frames to the Initial packet and/or by
-coalescing the Initial packet (see {{packet-coalesce}}). Sending a UDP datagram
-of this size ensures that the network path supports a reasonable Maximum
-Transmission Unit (MTU), and helps reduce the amplitude of amplification attacks
-caused by server responses toward an unverified client address; see
+The payload of a UDP datagram carrying Initial packets from a client MUST be
+expanded to at least 1200 bytes, by adding PADDING frames to the Initial packet
+and/or by coalescing the Initial packet (see {{packet-coalesce}}). Sending a UDP
+datagram of this size ensures that the network path supports a reasonable

```suggestion
datagram of this size ensures that the network path from the client to the server supports a reasonable
```

> @@ -3410,27 +3410,22 @@ later time in the connection.
 The QUIC packet size includes the QUIC header and protected payload, but not the
 UDP or IP header.
 
-Clients MUST ensure they send the first Initial packet in a single IP packet.
-Similarly, the first Initial packet sent after receiving a Retry packet MUST be
-sent in a single IP packet.
-
-The payload of a UDP datagram carrying the first Initial packet MUST be expanded
-to at least 1200 bytes, by adding PADDING frames to the Initial packet and/or by
-coalescing the Initial packet (see {{packet-coalesce}}). Sending a UDP datagram
-of this size ensures that the network path supports a reasonable Maximum
-Transmission Unit (MTU), and helps reduce the amplitude of amplification attacks
-caused by server responses toward an unverified client address; see
+The payload of a UDP datagram carrying Initial packets from a client MUST be
+expanded to at least 1200 bytes, by adding PADDING frames to the Initial packet
+and/or by coalescing the Initial packet (see {{packet-coalesce}}). Sending a UDP
+datagram of this size ensures that the network path supports a reasonable
+Maximum Transmission Unit (MTU), and helps reduce the amplitude of amplification

```suggestion
Maximum Transmission Unit (MTU). It also helps reduce the amplitude of amplification
```

>  {{address-validation}}.
 
-The datagram containing the first Initial packet from a client MAY exceed 1200
-bytes if the client believes that the Path Maximum Transmission Unit (PMTU)
-supports the size that it chooses.
+These datagrams containing Initial packets MAY exceed 1200 bytes if the client

```suggestion
Datagrams containing Initial packets MAY exceed 1200 bytes if the client
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3262#pullrequestreview-319580505