Re: [quicwg/base-drafts] H3 guidance on malformed request/response is light (#2410)

Kazuho Oku <notifications@github.com> Mon, 04 February 2019 17:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E1A00130EA0 for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 09:01:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.552
X-Spam-Level:
X-Spam-Status: No, score=-7.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_SUMOF=5, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ibOYwrUKKXs9 for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 09:01:35 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 24871130E86 for <quic-issues@ietf.org>; Mon, 4 Feb 2019 09:01:35 -0800 (PST)
Date: Mon, 04 Feb 2019 09:01:33 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549299693; bh=I1K/A7cmcKpuAJRL8+ICsMJHqrwPd8VOxK/nwHz71rg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hzIf5QuR609RLArWDwXJ2hiX6PFXgHXxjz+sPvo001rLiRpacm7YYH9QDKTFxd85a /tKP4grLmlcPMy2ZeSSzeZQpoNH/b0XyJDpjROSOjnLQ3V+bQAfLxTnH6vYQBzOpVw p+FqbmNrmKUNzv1iw9NbNpnlQrI2Yz343zwCA1pY=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8273e4e48282ec90b5916333231b7a2489e7972e92cf00000001187031ed92a169ce18394386@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2410/460326784@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2410@github.com>
References: <quicwg/base-drafts/issues/2410@github.com>
Subject: Re: [quicwg/base-drafts] H3 guidance on malformed request/response is light (#2410)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c586fedbc5c4_16af3f9f54ad45c02481d6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NoqBJCWl20amrAAqfpFzDW3iujI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 17:01:37 -0000

Nice catch!

I think I'd prefer using HTTP_GENERAL_PROTOCOL_ERROR or an error code just for this purpose rather than HTTP_MALFORMED_FRAME, because this is a framing error in the HTTP semantic layer, rather than an error in a HTTP/3 frame. The issue with using HTTP_MALFORMED_FRAME becomes most apparent when the request body is shorter than the sum of DATA frames, and if there is a trailer, the error will be detected when seeing the HEADERS frame. It would be strange to report the issue as HTTP_MALFORMED_FRAME(HEADERS) (because it's not an issue with the HEADERS frame), or as HTTP_MALFORMED_FRAME(DATA) (because none of the DATA frames that the client sent was malformed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2410#issuecomment-460326784