IETF Logo Mail Archive

Re: [quicwg/base-drafts] Version field <-> Version is not invariant (#3785)

Nick Harper <notifications@github.com> Wed, 01 July 2020 18:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 65BE33A09EE for <quic-issues@ietfa.amsl.com>; Wed, 1 Jul 2020 11:19:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GHHUnzN19An0 for <quic-issues@ietfa.amsl.com>; Wed, 1 Jul 2020 11:18:59 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A0DCD3A09E7 for <quic-issues@ietf.org>; Wed, 1 Jul 2020 11:18:59 -0700 (PDT)
Received: from github-lowworker-cd7bc13.ac4-iad.github.net (github-lowworker-cd7bc13.ac4-iad.github.net [10.52.25.102]) by smtp.github.com (Postfix) with ESMTP id D0EC38C0FAF for <quic-issues@ietf.org>; Wed, 1 Jul 2020 11:18:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1593627538; bh=WovGItMIxZC4AX2BEkqszp/42XS9RRJ3QdWcthH7Z2g=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Rv2zL78LEshw78Y+n2071cuDX17ibk71ULCCUXjVPuvfSKox2wXvysbQynhwtCvfE K2sSxdYqDRf34l+L/4xvB0yZVGHkYs/3qMXWnQAg9vTUJaQGx0gy7OTNYZ294eMkTY Bc6MmJm6wSi9nnupW8EpcXvkG/rak5B3Em76b/JI=
Date: Wed, 01 Jul 2020 11:18:58 -0700
From: Nick Harper <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK33DCRYPIRFOXPRRJF5BC2JFEVBNHHCMZ3PEU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3785/review/441088246@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3785@github.com>
References: <quicwg/base-drafts/pull/3785@github.com>
Subject: Re: [quicwg/base-drafts] Version field <-> Version is not invariant (#3785)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5efcd392c222f_27343f89bfacd9641693cb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nharper
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Nq_v9_tGKiGm_J_OiP28_1wysks>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Jul 2020 18:19:02 -0000

@nharper commented on this pull request.

I think this is a good change to be making.

> @@ -252,8 +252,9 @@ Packets for the same QUIC connection might use different connection ID values.
 
 ## Version
 
-QUIC versions are identified with a 32-bit integer, encoded in network byte
-order.  Version 0 is reserved for version negotiation (see
+The Version field contains a 32-bit integer, encoded in network byte order.

(If this is off-topic for this PR, please ignore.)

Is there a reason why we specify that the Version field is an integer, as opposed to a 32-bit value?

> @@ -252,8 +252,9 @@ Packets for the same QUIC connection might use different connection ID values.
 
 ## Version
 
-QUIC versions are identified with a 32-bit integer, encoded in network byte
-order.  Version 0 is reserved for version negotiation (see
+The Version field contains a 32-bit integer, encoded in network byte order.
+This value can be used by endpoints to identify a QUIC Version.  A Version field

If we end up with version ossification and the real version ends up in transport params, is it still the case that an endpoint can use the Version field to identify a QUIC Version? Perhaps "This value can be used by endpoints in identifying a QUIC Version" instead. That way there's room that an endpoint might consider other factors in identifying the QUIC Version used.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3785#pullrequestreview-441088246

v2.27.8 | Report a Bug | By Email | System Status