Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 4A46B130DDD
 for <quic-issues@ietfa.amsl.com>; Tue,  3 Jul 2018 06:50:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level: 
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1,
 RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01]
 autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id INgLF0FrAX3F for <quic-issues@ietfa.amsl.com>;
 Tue,  3 Jul 2018 06:49:59 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 201791294D7
 for <quic-issues@ietf.org>; Tue,  3 Jul 2018 06:49:59 -0700 (PDT)
Date: Tue, 03 Jul 2018 06:49:58 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1530625798;
 bh=7fThVKq4UCyCsKLCyBYz06F+HMJUDscQNtcM/EX9TDI=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=Wje7GzuqySkEK+DfLaQfXnSKDSQhVGzsV4eFz6nH3Nfq3+b9ijZYMaOqNI2q0qHpO
 ke/RteX8S4Eg3RI4yP9lHjZMUMupsedgfyRq19nkIHMuy0emcUiQAI+YlhAdimLAcN
 iJNLpOkq5hV0IAxUzvd3/Wu0ybwcC/NHkzy/hPk8=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab474bda5bf846ab9a9ff8565b9e63e4876531a19992cf000000011753410592a169ce1421be50@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1514/review/134002355@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1514@github.com>
References: <quicwg/base-drafts/pull/1514@github.com>
Subject: Re: [quicwg/base-drafts] Permit 0-RTT after Retry and VN (#1514)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b3b7f065f46_7a13f83dc760f801407db";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Nxm3KD_Y-E1E8JChWjIfo1BVi4k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jul 2018 13:50:02 -0000


----==_mimepart_5b3b7f065f46_7a13f83dc760f801407db
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

mikkelfj commented on this pull request.



> @@ -727,16 +732,17 @@ Connection ID.
 
 ### Tokens
 
-If the client has a token received in a NEW_TOKEN frame on a previous connection
-to what it believes to be the same server, it can include that value in the
-Token field of its Initial packet.
+If the client has an token received in a NEW_TOKEN frame on a previous

a token

> @@ -601,6 +601,11 @@ the packet.  This prevents an off-path attacker from injecting a Retry packet.
 The client responds to a Retry packet with Initial packet that includes the
 provided Retry Token to continue connection establishment.
 
+A client MAY attempt 0-RTT after receiving a Retry packet by sending 0-RTT
+packets to the connection ID provided by the server.  A client that sends
+additional 0-RTT packets MUST NOT reset the packet number to 0 after a Retry
+packet, see {{retry-0rtt-pn}}.
+

sugg: A server MAY reject a redirected 0-RTT attempt because the DCID does not match the 0-RTT token.

>  
-A client SHOULD NOT reuse a token.  Reusing a token on different network paths
-would allow activity to be linked between paths (see {{migration-linkability}}).
-A client MUST NOT reuse a token if it believes that its point of network
-attachment has changed; that is, if there is a change in its local IP address or
-network interface.  A client needs to start the connection process over if it
-migrates prior to completing the handshake.
+A client SHOULD NOT reuse a token; reused tokens enable activity on connections
+to be correlated.  A client MUST NOT reuse a token if it believes that its point
+of network attachment has changed; that is, if there is a change in its local IP
+address or network interface.  Reusing a token on different network paths would
+allow activity to be linked between paths (see {{migration-linkability}}).  A
+client needs to start the connection process over if it migrates prior to
+completing the handshake.
 

Redundant explanation using both "correlate" and "linked" in separate sentences.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1514#pullrequestreview-134002355
----==_mimepart_5b3b7f065f46_7a13f83dc760f801407db
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@mikkelfj</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1514#discussion_r199811273">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -727,16 +732,17 @@ Connection ID.
 
 ### Tokens
 
-If the client has a token received in a NEW_TOKEN frame on a previous connection
-to what it believes to be the same server, it can include that value in the
-Token field of its Initial packet.
+If the client has an token received in a NEW_TOKEN frame on a previous
</pre>
<p>a token</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1514#discussion_r199812335">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -601,6 +601,11 @@ the packet.  This prevents an off-path attacker from injecting a Retry packet.
 The client responds to a Retry packet with Initial packet that includes the
 provided Retry Token to continue connection establishment.
 
+A client MAY attempt 0-RTT after receiving a Retry packet by sending 0-RTT
+packets to the connection ID provided by the server.  A client that sends
+additional 0-RTT packets MUST NOT reset the packet number to 0 after a Retry
+packet, see {{retry-0rtt-pn}}.
+
</pre>
<p>sugg: A server MAY reject a redirected 0-RTT attempt because the DCID does not match the 0-RTT token.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1514#discussion_r199813337">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt;  
-A client SHOULD NOT reuse a token.  Reusing a token on different network paths
-would allow activity to be linked between paths (see {{migration-linkability}}).
-A client MUST NOT reuse a token if it believes that its point of network
-attachment has changed; that is, if there is a change in its local IP address or
-network interface.  A client needs to start the connection process over if it
-migrates prior to completing the handshake.
+A client SHOULD NOT reuse a token; reused tokens enable activity on connections
+to be correlated.  A client MUST NOT reuse a token if it believes that its point
+of network attachment has changed; that is, if there is a change in its local IP
+address or network interface.  Reusing a token on different network paths would
+allow activity to be linked between paths (see {{migration-linkability}}).  A
+client needs to start the connection process over if it migrates prior to
+completing the handshake.
 
</pre>
<p>Redundant explanation using both "correlate" and "linked" in separate sentences.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1514#pullrequestreview-134002355">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq8-N9x3ds9m6W5Wws1Tfd4PDyuFhks5uC3aGgaJpZM4VAVox">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq6NSnWbTo_LHFEECzx-eF3T6hMnpks5uC3aGgaJpZM4VAVox.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mikkelfj commented on #1514"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1514#pullrequestreview-134002355"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1514#pullrequestreview-134002355",
"url": "https://github.com/quicwg/base-drafts/pull/1514#pullrequestreview-134002355",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@mikkelfj commented on 1514",
"sections": [
{
"text": "",
"activityTitle": "**MikkelFJ**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@mikkelfj",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1514#pullrequestreview-134002355"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 352410161\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5b3b7f065f46_7a13f83dc760f801407db--

