Re: [quicwg/base-drafts] ACK of non-existent packet is illegal (#2302)

janaiyengar <notifications@github.com> Tue, 08 January 2019 23:59 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E2DD712D4ED for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 15:59:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.661
X-Spam-Level:
X-Spam-Status: No, score=-1.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UtmcOBVwg93i for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 15:59:49 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6251813115E for <quic-issues@ietf.org>; Tue, 8 Jan 2019 15:59:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=UtNMkAaD/x/4HlwjsVedMFsiaws=; b=iO3vuePVLeJNlRjJ bsOa20KEHekfWpJzSkz18lA06OYylb55JuLAi56IfF97LiooDAXw/Kz39n4BRiPQ fzP4uFDT75qdGHQl1BjYD/B5ACNP2bZg3bfUY8Je/zRMKicIhABrZ8ZmRrQHEyc7 4Aq0x3U+nxaRgYwmw/uwMsnN2No=
Received: by filter1874p1mdw1.sendgrid.net with SMTP id filter1874p1mdw1-32407-5C353973-8 2019-01-08 23:59:47.264129807 +0000 UTC m=+79765.577534721
Received: from github-lowworker-4f62d42.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0017p1iad2.sendgrid.net (SG) with ESMTP id 5Em93QlZREua0qI62OL4jQ for <quic-issues@ietf.org>; Tue, 08 Jan 2019 23:59:47.287 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-4f62d42.cp1-iad.github.net (Postfix) with ESMTP id 3E063C0B1F for <quic-issues@ietf.org>; Tue, 8 Jan 2019 15:59:47 -0800 (PST)
Date: Tue, 08 Jan 2019 23:59:47 +0000
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abaa2bd13a1426385dc772ed73147cf7dc0f7c20cc92cf00000001184cfb7392a169ce179f2fda@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2302/review/190512738@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2302@github.com>
References: <quicwg/base-drafts/pull/2302@github.com>
Subject: Re: [quicwg/base-drafts] ACK of non-existent packet is illegal (#2302)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3539733caa2_49883fd2b62d45c466012"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2MyX7KgCmWPnYawV9Y9F2HyODTv73zSR+24K sIoY8G/3+dZSubwcZh11b+uD9hNiCYnqA+bpYVenfPB/34dAYJMtytXB3hhrb1YQC+noDUT4qayTDV tXUHX2dcFeKFBInXgcR5DhY2efya2hatwX2KUngtuxUtyA8qxViM4T0HZo8TPHxkdDmocBFHMtzrtx Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/O6r6IZvqKBIbSe5xiyK9Lvqjlkg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 23:59:51 -0000

janaiyengar commented on this pull request.



>  acknowledgment of its ACK frames, with the knowledge this could cause the sender
 to unnecessarily retransmit some data.  Standard QUIC {{QUIC-RECOVERY}}
 algorithms declare packets lost after sufficiently newer packets are
 acknowledged.  Therefore, the receiver SHOULD repeatedly acknowledge newly
 received packets in preference to packets received in the past.
 
+An endpoint SHOULD treat receipt of an acknowledgment for a packet it did not
+send as a connection error of type PROTOCOL_VIOLATION, if it is able to detect

Let's do a separate discussion about error codes. I don't think it's necessary here, and if this is an important new error code, let's introduce that in a new issue/PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2302#discussion_r246211578