Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)
Mike Bishop <notifications@github.com> Wed, 19 August 2020 19:29 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D677B3A0D7E for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 12:29:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rHijpm3Z_UcT for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 12:29:39 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F3CA3A0D7C for <quic-issues@ietf.org>; Wed, 19 Aug 2020 12:29:39 -0700 (PDT)
Received: from github-lowworker-cd7bc13.ac4-iad.github.net (github-lowworker-cd7bc13.ac4-iad.github.net [10.52.25.102]) by smtp.github.com (Postfix) with ESMTP id 4A635840EFD for <quic-issues@ietf.org>; Wed, 19 Aug 2020 12:29:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597865378; bh=b1PKF6Esif2QsA86FHMOxX89MgP15ToM2vTpUzBWRm0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Zi/Az5hJWOiS6dNQ0YDzlpHEx9lOqPcLOm/0xM1Whzw83p1RFnaJqf7xvHaMycwPO FEuMnqvcw/SHm+t4lMEtO+HwllMf3XsUCm5fHyysDWjrN/s3KlELtzvhFvVISri/R9 EfWp8Ki5gdDsHlsLicnqZW2q61eDPn0irWjLwOH0=
Date: Wed, 19 Aug 2020 12:29:38 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7IP7J7UORVM7IJLTF5JFPKFEVBNHHCRJE2U4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4016/review/470768701@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4016@github.com>
References: <quicwg/base-drafts/pull/4016@github.com>
Subject: Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3d7da23b4d9_1f6319642188b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OB1szRFMpOexcnV_1BuHTRqhzG8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Aug 2020 19:29:41 -0000
@MikeBishop commented on this pull request. > +The definition of new transport parameters ({{new-transport-parameters}}) is +REQUIRED to specify whether they MUST, MAY, or MUST NOT be stored for 0-RTT. A ```suggestion The definition of a new transport parameter ({{new-transport-parameters}}) is REQUIRED to specify whether it MUST, MAY, or MUST NOT be stored for 0-RTT. A ``` I think the singular reads better, especially with the change in keyword. > @@ -1889,7 +1891,7 @@ confirms that the client received the Initial packet from the server. Once the server has successfully processed a Handshake packet from the client, it can consider the client address to have been validated. -Additionally, a server MAY consider the client address valididated if the +Additionally, a server MAY consider the client address validated if the 😄 > -subsequent ACK frames; see {{generating-acks}} and {{frame-ack}}. Note that -this requires being able to read the ECN codepoints from the enclosing IP -packet, which is not possible on all platforms. I'm not sure about this one. IIRC, we were pretty deliberate about adding this text to note that compliance with the ECN guidance was conditional on OS support for doing so. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/4016#pullrequestreview-470768701
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Jana Iyengar
- Re: [quicwg/base-drafts] Fix some of the nits in … Jana Iyengar
- Re: [quicwg/base-drafts] Fix some of the nits in … Jana Iyengar
- Re: [quicwg/base-drafts] Fix some of the nits in … Jana Iyengar
- [quicwg/base-drafts] Fix some of the nits in #321… Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Mike Bishop
- Re: [quicwg/base-drafts] Fix some of the nits in … Mike Bishop
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Martin Thomson
- Re: [quicwg/base-drafts] Fix some of the nits in … Mike Bishop
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Gorry Fairhurst
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Gorry Fairhurst
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Gorry Fairhurst
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Martin Thomson
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Mike Bishop
- Re: [quicwg/base-drafts] Fix some of the nits in … Lars Eggert
- Re: [quicwg/base-drafts] Fix some of the nits in … Jana Iyengar