[quicwg/base-drafts] Pseudocode for persistent congestion is too hard (#4080)
Martin Thomson <notifications@github.com> Tue, 08 September 2020 22:28 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3F13F3A045B for <quic-issues@ietfa.amsl.com>; Tue, 8 Sep 2020 15:28:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9THDufJ0oT-J for <quic-issues@ietfa.amsl.com>; Tue, 8 Sep 2020 15:28:42 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E2D3A3A03EE for <quic-issues@ietf.org>; Tue, 8 Sep 2020 15:28:41 -0700 (PDT)
Received: from github-lowworker-2300405.va3-iad.github.net (github-lowworker-2300405.va3-iad.github.net [10.48.17.39]) by smtp.github.com (Postfix) with ESMTP id 26B44E0D16 for <quic-issues@ietf.org>; Tue, 8 Sep 2020 15:28:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1599604121; bh=KDsCo1AUCS/dZy1MzZ7hQy7ndgP+41YZILopBdRrTuQ=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=HahAEDLqZlCM1m1v9kAg8Y4UCxabxwA98qSjsI+kA+AtabDlejN01VB9KTXRxP8d7 uAERPT+nJFqvK7jMNQQDezH1eX9eyh5dddaBb6/hnL9v6e91WrhdemmuFNE2vAKDlU fUTxrJpbyO53uEc923wSVN5jx1lQQB+nvf16e7rs=
Date: Tue, 08 Sep 2020 15:28:41 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5EOJIMDQ5WVZEDFJ55MPTJTEVBNHHCS73V5U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4080@github.com>
Subject: [quicwg/base-drafts] Pseudocode for persistent congestion is too hard (#4080)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f5805991777e_49cc19f01144ce"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OLZpYXbScbE0HAi5NNJLyIvfyfA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Sep 2020 22:28:43 -0000
This removes that function, relying instead on comments and the definition in text (which people have noted is now very clear). I have also reset a couple of extra variables in this case. It is important to catch all of these because if you don't you get poor outcomes. The only question I have is regarding bytes in flight. I think that we need to keep tracking those bytes, or the overall accounting gets messy. That is what our implementation does anyway. Closes #4010. Closes #3972. You can view, comment on, or merge this pull request online at: https://github.com/quicwg/base-drafts/pull/4080 -- Commit Summary -- * Pseudocode for persistent congestion is too hard -- File Changes -- M draft-ietf-quic-recovery.md (20) -- Patch Links -- https://github.com/quicwg/base-drafts/pull/4080.patch https://github.com/quicwg/base-drafts/pull/4080.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/4080
- [quicwg/base-drafts] Pseudocode for persistent co… Martin Thomson
- Re: [quicwg/base-drafts] Pseudocode for persisten… Martin Thomson
- Re: [quicwg/base-drafts] Pseudocode for persisten… ianswett
- Re: [quicwg/base-drafts] Pseudocode for persisten… Martin Thomson
- Re: [quicwg/base-drafts] Pseudocode for persisten… Martin Thomson
- Re: [quicwg/base-drafts] Pseudocode for persisten… Martin Thomson
- Re: [quicwg/base-drafts] Pseudocode for persisten… ianswett
- Re: [quicwg/base-drafts] Pseudocode for persisten… Martin Thomson
- Re: [quicwg/base-drafts] Pseudocode for persisten… Jana Iyengar
- Re: [quicwg/base-drafts] Pseudocode for persisten… Jana Iyengar
- Re: [quicwg/base-drafts] Pseudocode for persisten… Jana Iyengar
- Re: [quicwg/base-drafts] Pseudocode for persisten… Kazu Yamamoto
- Re: [quicwg/base-drafts] Pseudocode for persisten… Martin Thomson