Re: [quicwg/base-drafts] Reference RFC5681 and RFC6928 (#1245)

janaiyengar <notifications@github.com> Tue, 27 March 2018 19:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0572712DA53 for <quic-issues@ietfa.amsl.com>; Tue, 27 Mar 2018 12:09:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.391
X-Spam-Level:
X-Spam-Status: No, score=-5.391 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yfF6_-Hx821D for <quic-issues@ietfa.amsl.com>; Tue, 27 Mar 2018 12:09:29 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 94024120227 for <quic-issues@ietf.org>; Tue, 27 Mar 2018 12:09:00 -0700 (PDT)
Date: Tue, 27 Mar 2018 12:09:00 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1522177740; bh=4lSFC0A0N82uXuVBgl8MigrC2WLf1HFtkz2XldQ++e8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=sDhHIMJQphxLEzOEd6DSS1bQVqhVL45WDrZ2s9/4uaA7YM46QIQINAi/Ow4lrLaFT XRr7uruMQyppizbVvz1ubfQ4Jg4pF4LYQpYdpKGiuDy34Q4Jt8cMb3skLBkVE7/2uj mWfe7SyT/SWojR23e9TCuwLeXXiKWO7ftD20iAPg=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab98bd1a2853f22294546c19a4e2000bb61089893c92cf0000000116d258cc92a169ce124bf8bc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1245/review/106043989@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1245@github.com>
References: <quicwg/base-drafts/pull/1245@github.com>
Subject: Re: [quicwg/base-drafts] Reference RFC5681 and RFC6928 (#1245)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aba96cc2c71_5d322b25f3b20ec8107783"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ORSwdG6yTDIc64OXmdfHR-XHE7o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Mar 2018 19:09:31 -0000

janaiyengar commented on this pull request.



> @@ -974,6 +968,13 @@ kLossReductionFactor (default 0.5):
 Variables required to implement the congestion control mechanisms
 are described in this section.
 
+sender_mss:

I don't think we should use MSS, since the idea of a segment is TCP-specific. How about max_datagram_size?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1245#pullrequestreview-106043989