Re: [quicwg/base-drafts] Duplicates are dropped (#1624)

Kazuho Oku <notifications@github.com> Wed, 01 August 2018 07:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 93ADF130DF0 for <quic-issues@ietfa.amsl.com>; Wed, 1 Aug 2018 00:49:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.109
X-Spam-Level:
X-Spam-Status: No, score=-6.109 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kgmi9lwkyPp7 for <quic-issues@ietfa.amsl.com>; Wed, 1 Aug 2018 00:49:51 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A953A130DCC for <quic-issues@ietf.org>; Wed, 1 Aug 2018 00:49:51 -0700 (PDT)
Date: Wed, 01 Aug 2018 00:49:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533109790; bh=dCNq+gaKcj6RC9a6Jt0cNH88yzlY1bhSvdWivVtj1S4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wACddkRDJ7picoq1o5bbtHqq3cpuPKilVXUdAaaNJ4b1XOrAjfElYEvvM8o+xJ+YM LvtybAiPZJhPZgTjgcq2ZTA/TRT0JamnZfFeqCYzNLyR8usKrojxayeSuzMw04Kt1k 1uRkifbxYtMXP1VVICDPAwuEKR38Nu5OVA3dsDrg=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4ef64ba85eb4866dfc3c46cfd39381945e58f62f92cf000000011779281e92a169ce14a685b4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1624/c409483467@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1624@github.com>
References: <quicwg/base-drafts/pull/1624@github.com>
Subject: Re: [quicwg/base-drafts] Duplicates are dropped (#1624)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b61661eb7562_25753ffb5f4d45b4526d0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OSjWE136dPggd8wobgC-j5BK7aI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2018 07:49:54 -0000

> The protocol doesn't make any sense if you get (valid) duplicates and don't discard them.

I think we have different opinions here. My understanding is that processing of a “valid” duplicate (i.e, a packet that has the same PN and same payload as what have been observed earlier) is perfectly fine, because processing the payload of such packet does not cause any change in state. Processing of previously-observed frames are guaranteed to be idempotent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1624#issuecomment-409483467