Date: Thu, 30 Jul 2020 12:04:47 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK2IO4XP2NWTCFKMPC55F35M7EVBNHHCPTRR6M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3971/review/458677596@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3971@github.com>
References: <quicwg/base-drafts/pull/3971@github.com>
Subject: Re: [quicwg/base-drafts] Clarify ACK Delay and reference host-delay
 (#3971)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5f2319cfe0648_4dd216f853331";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OT6L0pNjvgLjaap5BBpsLX_E_1E>


----==_mimepart_5f2319cfe0648_4dd216f853331
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@ianswett commented on this pull request.



> +: A variable-length integer encoding the intentional delay between when the
+  largest acknowledged packet, as indicated in the Largest Acknowledged field,
+  was received, and when the ACK frame was sent; see {{host-delay}}.
+  The acknowledgement delay in microseconds is the value of the ACK Delay
+  field multiplied by 2 to the power of the ack_delay_exponent transport
+  parameter sent by the sender of the ACK frame;
+  see {{transport-parameter-definitions}}.  Scaling in this fashion allows for
+  a larger range of values with a shorter encoding at the cost of lower
+  resolution.  Because the receiver doesn't use the ACK Delay for Initial and
+  Handshake packets, a sender SHOULD send a value of 0.

Thanks, I kept most of the existing sentence about size vs resolution, but otherwise took your suggestion @janaiyengar 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3971#discussion_r463209354
----==_mimepart_5f2319cfe0648_4dd216f853331
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3971#discussion_r463209354">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; +: A variable-length integer encoding the intentional delay between when the
+  largest acknowledged packet, as indicated in the Largest Acknowledged field,
+  was received, and when the ACK frame was sent; see {{host-delay}}.
+  The acknowledgement delay in microseconds is the value of the ACK Delay
+  field multiplied by 2 to the power of the ack_delay_exponent transport
+  parameter sent by the sender of the ACK frame;
+  see {{transport-parameter-definitions}}.  Scaling in this fashion allows for
+  a larger range of values with a shorter encoding at the cost of lower
+  resolution.  Because the receiver doesn&#39;t use the ACK Delay for Initial and
+  Handshake packets, a sender SHOULD send a value of 0.
</pre>
<p>Thanks, I kept most of the existing sentence about size vs resolution, but otherwise took your suggestion <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/janaiyengar/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/janaiyengar">@janaiyengar</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3971#discussion_r463209354">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK235CK5TFM4MEKTISDR6G747ANCNFSM4PLSGB3Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK2HMYXQPBVNCJ5ZPYLR6G747A5CNFSM4PLSGB32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODNLN2XA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3971#discussion_r463209354",
"url": "https://github.com/quicwg/base-drafts/pull/3971#discussion_r463209354",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5f2319cfe0648_4dd216f853331--