[quicwg/base-drafts] c78a39: Forbid duplicate setting identifiers. (#2979)
Bence Béky <noreply@github.com> Mon, 26 August 2019 19:13 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E9FD120D10 for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 12:13:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7
X-Spam-Level:
X-Spam-Status: No, score=-7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AQKA7mvkjoLG for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 12:13:54 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B11BB120CE9 for <quic-issues@ietf.org>; Mon, 26 Aug 2019 12:13:54 -0700 (PDT)
Date: Mon, 26 Aug 2019 12:13:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566846834; bh=couvnZ+3lfKTmhW/QE/uUfGKYvEaykSs8zhSWGmH5Rg=; h=Date:From:To:Subject:From; b=io5m3lHFpdvS9xMxX04AWoBnTgM1cwq3kK4l/cTj9wHcZKOWRo7I4WTpBadL5/wnh ZSIXk5Gy8ip+ittsauZ1SbmzFDnOu0m6MNxucr75gofNqIkKi0uW7FlvzY1RfPgr4B 4Xdq0XCttoLNYAt6a+7iVd34yzuHmuNBiSpd7bRI=
From: Bence Béky <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/master/bed467-c78a39@github.com>
Subject: [quicwg/base-drafts] c78a39: Forbid duplicate setting identifiers. (#2979)
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OVRXBTfnrN-IfigAcq07mDKqda8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Aug 2019 19:14:01 -0000
Branch: refs/heads/master Home: https://github.com/quicwg/base-drafts Commit: c78a39599540b6c6f3dfa5ebb454442acbfb4ae7 https://github.com/quicwg/base-drafts/commit/c78a39599540b6c6f3dfa5ebb454442acbfb4ae7 Author: Bence Béky <bencebeky@users.noreply.github.com> Date: 2019-08-26 (Mon, 26 Aug 2019) Changed paths: M draft-ietf-quic-http.md Log Message: ----------- Forbid duplicate setting identifiers. (#2979) * Forbid duplicate setting identifiers. I assume the intention was to forbid the same setting identifier occurring multiple times in a SETTINGS frame, regardless of the values. However, since a parameter is defined as an identifier-value pair, the current text does not forbid duplicate identifiers if the values are different. * Apply suggestions from code review Thanks for the suggestion, I like it. Co-Authored-By: Martin Thomson <mt@lowentropy.net> * Reflow text.