Re: [quicwg/base-drafts] ACK-only packets are not congestion controlled (#3453)

Kazuho Oku <notifications@github.com> Thu, 13 February 2020 00:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 13D8D120047 for <quic-issues@ietfa.amsl.com>; Wed, 12 Feb 2020 16:24:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tNMm2UDUZq5B for <quic-issues@ietfa.amsl.com>; Wed, 12 Feb 2020 16:24:15 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3E270120019 for <quic-issues@ietf.org>; Wed, 12 Feb 2020 16:24:15 -0800 (PST)
Received: from github-lowworker-ca5950c.va3-iad.github.net (github-lowworker-ca5950c.va3-iad.github.net [10.48.17.57]) by smtp.github.com (Postfix) with ESMTP id F211966091F for <quic-issues@ietf.org>; Wed, 12 Feb 2020 16:24:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581553453; bh=WtFp7kASPxSH99eVK/CTZoAWj2M6DhSVME9nT/0OZww=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dtRRGCg4Iln+Te0jEvFQp05XzC2WSZYLfq473FvLWdBdc5DPIuQWmW3gnFmxrpfv0 cjJgWSxhJDW+f0pSwMt82N12W8mweGEalDS/wKEbBj0BJConzlyxVRgRzeeDpWUOpC BozdnugPwRQDfsnT40/mc0CAapHH7cNdltiJ1EJ0=
Date: Wed, 12 Feb 2020 16:24:13 -0800
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK27FFT2JZCPITKTLXF4KHE23EVBNHHCDI3TA4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3453/review/357882130@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3453@github.com>
References: <quicwg/base-drafts/pull/3453@github.com>
Subject: Re: [quicwg/base-drafts] ACK-only packets are not congestion controlled (#3453)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e44972de1696_20183fd6ac8cd9683149ce"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OVhAF0maZ2FtSUwR-hNj8K9Zgl0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Feb 2020 00:24:17 -0000

kazuho approved this pull request.

:+1: Thank you for the PR. LGTM, and to me it seems that the add text is at the right location.

Using the loss of ACK-only packets is one way of deviating from CC that is described in this document, and therefore it seems correct to me to have that stated right after the general requirements regarding CC when one chooses a design that is different from what is being specified in quic-recovery.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3453#pullrequestreview-357882130