Re: [quicwg/base-drafts] Acknowledge stream resets too (#1400)
Martin Thomson <notifications@github.com> Thu, 14 June 2018 02:57 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3970E130FF2 for <quic-issues@ietfa.amsl.com>; Wed, 13 Jun 2018 19:57:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JPZRhgob1bQ3 for <quic-issues@ietfa.amsl.com>; Wed, 13 Jun 2018 19:57:40 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 51D0912D7F8 for <quic-issues@ietf.org>; Wed, 13 Jun 2018 19:57:40 -0700 (PDT)
Date: Wed, 13 Jun 2018 19:57:39 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1528945059; bh=5fPc74NE85paoskZXdMQBxJYWr4gYeBsPAmfulYbHJw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AznOjj3mJPYbIsqyNN556M0vvj6Bq6JLTcWZoSU6BhP3noCidYXb4VWLZ7jQOcLrU CA4UWl0yH8TFUQhzU32tV47qCXQi/jjgi0evOSlGWT6f0c4TII4GebrgloH5vrQhF2 NcjL8Qb11bT36PQeZ99/26QF1ktl8Cq6qx8T9vSM=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abccb5d29c6fbaa8258d8ec4ad5fc3b1d600e305e492cf0000000117399ba392a169ce138608d0@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1400/review/128628259@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1400@github.com>
References: <quicwg/base-drafts/pull/1400@github.com>
Subject: Re: [quicwg/base-drafts] Acknowledge stream resets too (#1400)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b21d9a3adcab_26a8f3fd3a017ef7c437fd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OVhWekUeio4gSPGoniOISgNw4fY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 02:57:42 -0000
martinthomson commented on this pull request. > + +A decoder MUST track increases to the largest acknowledged dynamic table entry +caused by acknowledging a header block so that it can correctly generate the +Table State Synchronize instruction. + + +### Stream Cancellation + +A stream that is reset might have multiple outstanding header blocks. A decoder +that receives a stream reset before the end of a stream generates a Stream +Cancellation instruction on the decoder stream. Similarly, a decoder that +abandons reading of a stream needs to signal this using the Stream Cancellation +instruction. This signals to the encoder that all references to the dynamic +table on that stream are no longer outstanding. + +An encoder cannot infer from this acknowledgement that any updates to the This builds on top of #1399 (You can view the changes here: https://github.com/quicwg/base-drafts/compare/implicit-ack-header-block...ack-reset-stream I assumed - incorrectly - that you had already seen these changes, so pointed this at master rather than the other PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1400#discussion_r195290927
- Re: [quicwg/base-drafts] Acknowledge stream reset… afrind
- Re: [quicwg/base-drafts] Acknowledge stream reset… Martin Thomson
- Re: [quicwg/base-drafts] Acknowledge stream reset… Martin Thomson
- Re: [quicwg/base-drafts] Acknowledge stream reset… afrind
- Re: [quicwg/base-drafts] Acknowledge stream reset… Martin Thomson
- [quicwg/base-drafts] Acknowledge stream resets to… Martin Thomson
- Re: [quicwg/base-drafts] Acknowledge stream reset… Martin Thomson
- Re: [quicwg/base-drafts] Acknowledge stream reset… Mike Bishop
- Re: [quicwg/base-drafts] Acknowledge stream reset… Martin Thomson
- Re: [quicwg/base-drafts] Acknowledge stream reset… Mike Bishop
- Re: [quicwg/base-drafts] Acknowledge stream reset… Martin Thomson
- Re: [quicwg/base-drafts] Acknowledge stream reset… Martin Thomson
- Re: [quicwg/base-drafts] Acknowledge stream reset… afrind